rpc: Generate auth cookie in hex instead of base64 #8858

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2016_10_01_moar_cookies changing 1 files +4 −3

laanwj commented at 3:01 PM on October 1, 2016: member

Base64 contains '/', and the '/' character in credentials is problematic for AuthServiceProxy which represents the RPC endpoint as an URI with user and password embedded.

Closes #8399. @gmaxwell

rpc: Generate auth cookie in hex instead of base64

Base64 contains '/', and the '/' character in credentials is problematic
for AuthServiceProxy which represents the RPC endpoint as an URI with
user and password embedded.

Closes #8399.

1c80386bce

laanwj added the label RPC/REST/ZMQ on Oct 1, 2016
MarcoFalke commented at 3:25 PM on October 1, 2016: member

utACK 1c80386bceb216ca5b5da657e03a29f9c779d58b
btcdrak commented at 7:03 PM on October 1, 2016: contributor

utACK 1c80386
dcousens commented at 12:51 AM on October 2, 2016: contributor

utACK 1c80386, but base58 could have worked, not sure if that matters though.
laanwj commented at 7:16 AM on October 2, 2016: member

utACK 1c80386, but base58 could have worked, not sure if that matters though.

Thought about that, but I eventually decided on hex. It doesn't matter here, but if there's no need to introduce a dependency on something so bitcoin-specific in general RPC protocol code that may be better. Hex encoding on the other hand is trivial and readily available.
paveljanik commented at 7:49 AM on October 2, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/8858/commits/1c80386bceb216ca5b5da657e03a29f9c779d58b
gmaxwell commented at 12:28 AM on October 3, 2016: contributor

ACK.

Thanks for fixing this problem I reported then forgot about.
sipa commented at 12:35 AM on October 3, 2016: member

utACK.
laanwj merged this on Oct 3, 2016
laanwj closed this on Oct 3, 2016
laanwj referenced this in commit 6f3ef551fa on Oct 3, 2016
laanwj referenced this in commit 3f508edcfb on Oct 18, 2016
jtimon referenced this in commit 360fbefdef on Nov 24, 2016
jtimon referenced this in commit 6c1a016a64 on Feb 2, 2017
furszy referenced this in commit 0255df35a6 on Apr 26, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8399 Cookie auth picks passwords which are incompatible with some URL parsers