Make GetFetchFlags always request witness objects from witness peers #8871

1. 
   TheBlueMatt commented at 5:04 pm on October 3, 2016: member

   This fixes a bug where we might (in exceedingly rare circumstances) accidentally ban a node for sending us the first (potentially few) segwit blocks in non-segwit mode.

   See #8393 (review) for the compact-block-related issue, though there is a similar(ly rare) version in ::INV processing as well.

2. Make GetFetchFlags always request witness objects from witness peers

   This fixes a bug where we might (in exceedingly rare circumstances)
   accidentally ban a node for sending us the first (potentially few)
   segwit blocks in non-segwit mode.

   2da86f9066
3. TheBlueMatt force-pushed on Oct 3, 2016
4. Fix overly-prescriptive p2p-segwit test for new fetch logic 84a32a8acf
5. TheBlueMatt force-pushed on Oct 3, 2016
6. dcousens approved
7. 
   dcousens commented at 9:04 pm on October 3, 2016: contributor

   concept ACK, utACK
8. laanwj added the label P2P on Oct 4, 2016
9. 
   sdaftuar commented at 7:12 pm on October 4, 2016: member

   ACK
10. 
    btcdrak commented at 7:17 pm on October 5, 2016: contributor

    utACK 84a32a8acfe184041dedfc547d68a9a451406bec
11. 
    NicolasDorier commented at 3:45 pm on October 7, 2016: contributor

    might be worth dropping the pprev parameter completely?
12. 
    TheBlueMatt commented at 9:21 pm on October 9, 2016: member

    This late in 13.1, I wanted to touch as little code as possible. I’d call that a candidate for cleanup in 14.

    On October 7, 2016 5:45:50 PM GMT+02:00, Nicolas Dorier notifications@github.com wrote:

    might be worth droppied the pprev parameter completely?

    You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #8871 (comment)

13. 
    btcdrak commented at 11:03 pm on October 9, 2016: contributor

    @TheBlueMatt is this for backport?
14. 
    TheBlueMatt commented at 8:00 am on October 10, 2016: member

    @btcdrak Yes, #8393 is now rebased on top of this.
15. fanquake added this to the milestone 0.13.1 on Oct 10, 2016
16. fanquake added the label Needs backport on Oct 10, 2016
17. MarcoFalke removed the label Needs backport on Oct 10, 2016
18. 
    MarcoFalke commented at 11:30 am on October 10, 2016: member

    I guess this will be backported through #8393 .
19. MarcoFalke closed this on Oct 10, 2016

    ---

20. MarcoFalke locked this on Sep 8, 2021

Contributors
TheBlueMatt dcousens sdaftuar btcdrak NicolasDorier MarcoFalke

Labels
P2P

Milestone
0.13.1