Multiple Selection for peer and ban tables #8874

achow101 commented at 12:07 AM on October 4, 2016: member

Allows multiple selection and action for the nodes in the peer and ban tables in the Debug Window.

Closes #8864

fanquake added the label GUI on Oct 4, 2016

fanquake commented at 3:12 AM on October 4, 2016: member

OS X screenshots: Current before 8874 after

When multiple nodes are selected the dropdown menu should be "Nodes".

paveljanik commented at 5:06 AM on October 4, 2016: contributor

concept ACK

... or you can change the text to "Disconnect" and "Ban for 1 hour". I think we should use consistent terminology here. The bookmark is called "Peers" and we use "node" here. RPCs are getpeerinfo, addnode. Oops. But at least GUI should be consistent.

luke-jr commented at 5:17 AM on October 4, 2016: member

Our peers are nodes. Different terms for different things. Peer is the relationship, node is the thing.

Truncating the menu items does seem like the simplest approach here, though.

achow101 force-pushed on Oct 4, 2016

achow101 commented at 12:33 PM on October 4, 2016: member

I've just removed Node so that it says Disconnect, Ban for .., and Unban

laanwj commented at 2:37 AM on October 5, 2016: member

Probably need #8885 in first to be able to test this re:banning.

laanwj commented at 3:32 AM on October 5, 2016: member

Have tested d651056 I've been unable to ban/kick multiple peers. Either with Ctrl-click or Shift-click. Is there some other trick? Ubuntu 16.04, Qt reports as 5.5.1. It seems like it allows multiple selection (e.g. two nodes can be selected for a fraction of a second) but always ends up selecting the last clicked node. Maybe some rogue event handler?

achow101 commented at 3:45 AM on October 5, 2016: member

Click, hold, and move your mouse across multiple rows. That's what works. I haven't figured out Ctrl+click or Shift+click yet.

achow101 force-pushed on Oct 5, 2016

achow101 commented at 4:54 AM on October 5, 2016: member

@laanwj 763cc02 should allow for multiple selection with Ctrl-click, shift-click, and click n' drag.

jonasschnelli commented at 3:15 PM on October 8, 2016: contributor

Needs rebase.

in src/qt/rpcconsole.cpp:None in 763cc023a4 outdated

1021 | +
1022 | +        CNetAddr resolved;
1023 | +        if(!LookupHost(addr.c_str(), resolved, false))
1024 | +            continue;
1025 | +        g_connman->Ban(resolved, BanReasonManuallyAdded, bantime);
1026 | +        clearSelectedNode();

jonasschnelli commented at 3:17 PM on October 8, 2016:

I think the clearSelectedNode(); and L1008 can be moved out of the for loop

achow101 commented at 2:50 PM on October 9, 2016:

Done

achow101 force-pushed on Oct 8, 2016

achow101 commented at 11:37 PM on October 8, 2016: member

rebased

jonasschnelli changes_requested

jonasschnelli commented at 10:07 AM on October 9, 2016: contributor

Tested a bit. Selecting multiple peers (with shift key or with the mouse) results in some of them getting deselected short after the selection.

achow101 force-pushed on Oct 9, 2016

achow101 commented at 2:51 PM on October 9, 2016: member

I'm not sure why some of them get deselected. I noticed that too, but I can't figure out a reason for why that happens.

rebroad commented at 1:18 AM on October 19, 2016: contributor

Can we use keyboard shortcuts for selecting as per GUI standards? I.e. hold down shift while using the a cursor up/down to select multiple, or using spacebar and cursor up/down to toggle whether a node is selected or not (once at least one node is selected)?

achow101 commented at 1:34 AM on October 19, 2016: member

@rebroad It's whatever QAbstractItemView::ExtendedSelection specifies

luke-jr referenced this in commit 7ec15f7ef9 on Oct 20, 2016

jonasschnelli commented at 7:43 AM on November 8, 2016: contributor

@achow101: Are you planing to finalizing this? IMO there are still the issue with auto-deselecting rows.

achow101 commented at 1:18 PM on November 8, 2016: member

@jonasschnelli Yes, I do plan on finishing this. However, I am having trouble with figuring out why there is auto-deselecting.

Multiple Selection for peer and ban tables

Allows multiple selection and action for the nodes in the peer and ban tables in the Debug Window.

addfdebe1a

achow101 force-pushed on Nov 8, 2016

achow101 commented at 1:52 PM on November 8, 2016: member

rebased.

I think I figured out why it was auto-deselecting. It loses the selection after the model is refresehed.

achow101 commented at 3:42 PM on November 8, 2016: member

I think I fixed the problem.

Fix auto-deselection of peers 1077577546

achow101 force-pushed on Nov 8, 2016

achow101 commented at 8:12 PM on November 8, 2016: member

Actually fixed it this time.

paveljanik commented at 8:42 PM on November 8, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/8874/commits/1077577546334bc26daa3ab8580f24063a0b67c6

laanwj commented at 10:05 AM on November 9, 2016: member

Seems to work well enough now. If there are still minor issues with selection they can be fixed later. ACK 1077577

laanwj merged this on Nov 9, 2016

laanwj closed this on Nov 9, 2016

laanwj referenced this in commit e9847303e7 on Nov 9, 2016

jonasschnelli commented at 10:18 AM on November 9, 2016: contributor

Post merge ACK.

luke-jr referenced this in commit b10923243a on Dec 21, 2016

luke-jr referenced this in commit 4b8ec55af5 on Dec 21, 2016

achow101 deleted the branch on Apr 5, 2017

codablock referenced this in commit 845fecf595 on Sep 9, 2017

codablock referenced this in commit 23fb5b6c82 on Sep 11, 2017

UdjinM6 referenced this in commit 91d99fcd3f on Sep 11, 2017

DrahtBot locked this on Sep 8, 2021