This seems to look nice in virtually all colour themes (except Zion Reversed, but frankly my dislike of how it looked with that extended to more than just the overlay...)
Qt/ModalOverlay: Use theme tooltip colours #8889
pull luke-jr wants to merge 3 commits into bitcoin:master from luke-jr:overlay_theme changing 5 files +52 −20-
luke-jr commented at 4:47 AM on October 5, 2016: member
- fanquake added the label GUI on Oct 5, 2016
-
fanquake commented at 5:19 AM on October 5, 2016: member
OS X before & after, the background is now a yellowish colour vs the original grey.
-
laanwj commented at 7:50 AM on October 5, 2016: member
OS X before & after, the background is now a yellowish colour vs the original grey.
Tooltip-yellow! Like sticking a post-it over the interface.
Going to test this, as I have a somewhat unconventional theme.
Before:
After:
Big white blob or not, the original is better-readable. Also what's up with the corners?
-
luke-jr commented at 9:06 AM on October 5, 2016: member
Uh, the colours used are tooltip-text on tooltip-bg. You have white-on-white tooltips?? :/
I don't know anything about corners... saw something in the stylesheet, but it didn't seem to do anything?
-
MarcoFalke commented at 9:10 AM on October 5, 2016: member
Same problem as @laanwj on default fedora skin. Also, we should make sure gitian builds work fine with it.
-
rebroad commented at 1:19 AM on October 19, 2016: contributor
I saw the PR for this overlay yet I have yet to see it on my running bitcoin-qt . How do I make this appear please?
-
luke-jr commented at 3:51 AM on October 19, 2016: member
Leave your node (presumably testnet) offline for a few days, then when you start it, prevent it from syncing entirely by stopping it after it fetches headers, then start it again with -connect=0 to prevent it from getting connections.
-
laanwj commented at 12:28 PM on October 25, 2016: member
Uh, the colours used are tooltip-text on tooltip-bg. You have white-on-white tooltips?? :/
Tooltips are white on grey, just like everything else.
There's no canary-yellow in my theme at all.I don't know anything about corners... saw something in the stylesheet, but it didn't seem to do anything?
Looking at the screenshots they used to be nice and rounded, with the patch they're just square.
-
luke-jr commented at 10:19 AM on November 11, 2016: member
Will get back to this later
- luke-jr closed this on Nov 11, 2016
-
Qt/PlatformStyle: Expose explicit Colorize{Icon,Image} for public use 16d2124215
-
Qt/ModalOverlay: Use theme tooltip colours 51038c90f8
-
Qt/ModalOverlay: Adjust behind-overlay fade-out slightly for darker overlay backgrounds f8a28dcd78
- luke-jr reopened this on Nov 24, 2016
- luke-jr force-pushed on Nov 24, 2016
-
luke-jr commented at 3:58 AM on November 24, 2016: member
@laanwj @MarcoFalke Please test
-
fanquake commented at 5:28 AM on November 24, 2016: member
OS X 10.12, QT 5.7.0
-
MarcoFalke commented at 12:41 PM on November 24, 2016: member
Still the same:
-
luke-jr commented at 9:31 PM on November 24, 2016: member
@MarcoFalke Do your tooltips work? Can you investigate why you seem to have white-on-white palette here?
-
fanquake commented at 5:06 AM on January 15, 2017: member
Going to close this for now. Seems there are still issues to solve with the yellow-tooltip colouring. Can revisit when some more research has been done.
- fanquake closed this on Jan 15, 2017
-
katesalazar commented at 7:09 PM on August 5, 2021: contributor
These look sweet in my Plasma Breeze and Plasma Breeze Dark themes. No matter if wallet is opened or not, all 4 combinations are as good with this as in the master tip d67330d112.
It doesn't build on my system right away because of some Qt dependency mismatch I was lazy to investigate, but merge/rebase conflicts to master tip d67330d112 are easy<sup>[1]</sup>.
<sub>[1]: I actually merged (didn't look at rebasing) master fd9c22ca69 of three days ago which should be similar.</sub>
- DrahtBot locked this on Aug 18, 2022
Labels