Untranslated strings in GUI #8900

issue FabioCarpi-zz opened this issue on October 7, 2016
  1. FabioCarpi-zz commented at 2:48 PM on October 7, 2016: none

    I'm using the pt-br interface and some texts are appearing in English. v 0.13

  2. MarcoFalke commented at 5:05 PM on October 7, 2016: member

    According to the release process we are only syncing translation from transifex before every rc.

  3. FabioCarpi-zz commented at 5:44 PM on October 7, 2016: none

    But these texts alread translated

  4. fanquake added the label GUI on Oct 8, 2016
  5. fanquake commented at 10:36 AM on October 8, 2016: member

    @FabioCarpi Can you give us some example strings, or screenshots?

  6. MarcoFalke commented at 10:46 AM on October 8, 2016: member

    I think he refers to the recent translations on transifex, which are not yet fetched: https://www.transifex.com/user/profile/FabioCarpi/#activity

  7. MarcoFalke commented at 10:49 AM on October 8, 2016: member

    They are going to be included in https://github.com/bitcoin/bitcoin/releases/tag/v0.13.1rc1 which is not out yet, so closing the issue for now.

  8. MarcoFalke closed this on Oct 8, 2016

  9. FabioCarpi-zz commented at 2:33 PM on October 8, 2016: none

    No @MarcoFalke. Are windows that always have translation, but are not showing translated after the last updates

  10. MarcoFalke commented at 2:39 PM on October 8, 2016: member

    Hmm, in this case I am going to quote @fanquake

    @FabioCarpi Can you give us some example strings, or screenshots?

  11. FabioCarpi-zz commented at 4:57 PM on October 8, 2016: none

    @MarcoFalke as requested capturar

  12. MarcoFalke reopened this on Oct 8, 2016

  13. jonasschnelli commented at 2:16 PM on October 9, 2016: contributor

    I can confirm the issue. Somehow the tr()-strings in AddressBookPage are not getting translated.

  14. fanquake renamed this:
    Translates
    Untranslated strings in GUI
    on Oct 10, 2016
  15. laanwj commented at 3:23 PM on October 11, 2016: member

    Confirmed: The tr() strings in addressbookpage.cpp don't even end up in the translation - not even the English one.

    $ git grep "Choose the address to send coins to"
    src/qt/addressbookpage.cpp:        case SendingTab: setWindowTitle(tr("Choose the address to send coins to")); break;
    

    The reason for this is that that cpp file does not end up on the command line to lupdate in make translate.

  16. laanwj commented at 3:32 PM on October 11, 2016: member

    Many of the cpp's don't, because of:

    if ENABLE_WALLET
    BITCOIN_QT_CPP += \
      qt/addressbookpage.cpp \
      ...
    endif
    

    Wallet was disabled. Maybe that is the problem: make translate still works when you build without wallet support, however the strings from the .cpp files will not be included.

    It is possible that the system I use for generating the translations to upload doesn't have the wallet enabled. I had some issues here on Xenial and had to fall back to a Trusty VM. This could be the cause of the issue.

  17. fanquake commented at 9:51 AM on October 13, 2016: member

    Should be fixed by #8911

  18. fanquake closed this on Oct 13, 2016

  19. laanwj commented at 10:40 AM on October 13, 2016: member

    Yes - I've just pushed a commit to 0.13, 633c4a1f3690152bdda4b0ac7bcfde22c237183e, which when picked up by Transifex will enable the wallet messages to be translated again. Sorry for the mess.

  20. MarcoFalke commented at 9:00 AM on October 15, 2016: member

    I am wondering if it is possible to "translate" those "new" string on transifex by a script.

  21. FabioCarpi-zz commented at 5:12 PM on October 24, 2016: none

    Just saying, in version 0.13.1rc2, the problem continues...

  22. MarcoFalke commented at 7:01 PM on October 24, 2016: member

    @FabioCarpi Unfortunately the translated string "fell out" of the transifex translation system. There may be a way to read them from the transifex cache and submit them via the api in an automated manner.

    I am not sure if @luke-jr has some script for the transifex api. (I remember this was up for discussion when changing the product name to as few places as possible, but I don't recall if a script emerged from that...)

  23. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me