Don't request compact blocks when blocksonly=1 #8902

issue zstardust opened this issue on October 9, 2016

zstardust commented at 3:54 AM on October 9, 2016: none

2016-10-09 03:41:17.664724 Requesting block 0000000000000000016015e13560603164ddf4cdf439e13334f5f160d82419f0 from  peer=7
2016-10-09 03:41:19.681908 received: cmpctblock (12681 bytes) peer=7
2016-10-09 03:41:19.682682 sending: getblocktxn (2105 bytes) peer=7
2016-10-09 03:43:22.326699 received: blocktxn (987841 bytes) peer=7
2016-10-09 03:43:24.187977 UpdateTip: new best=0000000000000000016015e13560603164ddf4cdf439e13334f5f160d82419f0 height=433551 version=0x20000000 log2_work=85.383338 tx=161771820 date='2016-10-09 03:40:43' progress=0.999999 cache=26.4MiB(5697tx) warning='5 of last 100 blocks have unexpected version'

Without a memory pool compact blocks is less than efficient.

laanwj added the label P2P on Oct 9, 2016
rebroad commented at 10:26 AM on October 12, 2016: contributor

I'm confused.. How did peer 7 determine to send a 12681 byte cmpctblock to a peer with no memory pool? Compact blocks implementation must be pretty broken if this happens, IMHO...
zstardust commented at 12:16 AM on October 13, 2016: none

Can you explain this behavior @TheBlueMatt?
sipa commented at 12:26 PM on October 13, 2016: member

See #8800 to fix this.
rebroad referenced this in commit 6acadfeabc on Oct 18, 2016
adamjonas commented at 7:08 PM on December 16, 2020: member

Believe this was closed by #9375 (which #8800 closed in favor of).
adamjonas closed this on Jan 15, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

Labels

Linked (view graph)

#8964 Don't request compact blocks in blocksonly mode