Add copyright/patent issues to possible NACK reasons #8915

pull petertodd wants to merge 1 commits into bitcoin:master from petertodd:2016-10-13-sound-legal-justification changing 1 files +3 −1

petertodd commented at 5:40 PM on October 13, 2016: contributor

Adding in response to a Slack discussion where someone was unclear on the fact that a NACK may be justified if code can't be accepted due to copyright/patent issues. For example, it would be reasonable and prudent to NACK a contribution of AGPL-licensed consensus code on the basis that the license terms are incompatible with the MIT license used by the rest of the codebase.
fanquake added the label Docs and Output on Oct 13, 2016

Add copyright/patent issues to possible NACK reasons

Adding in response to a Slack discussion where someone was unclear on the fact
that a NACK may be justified if code can't be accepted due to copyright/patent
issues.  For example, it would be reasonable and prudent to NACK a contribution
of AGPL-licensed consensus code on the basis that the license terms are
incompatible with the MIT license used by the rest of the codebase.

36f60a5d5b

in CONTRIBUTING.md:None in 591bf24847 outdated

 177 | @@ -178,7 +178,9 @@ language is used within pull-request comments:
 178 |  
 179 |    - ACK means "I have tested the code and I agree it should be merged";
 180 |    - NACK means "I disagree this should be merged", and must be accompanied by
 181 | -    sound technical justification. NACKs without accompanying reasoning may be disregarded;
 182 | +    sound technical justification (or in certain cases of copyright/patent

btcdrak commented at 5:45 PM on October 13, 2016:

add /licensing because patches may also be unable to be included if the licensing is incompatible with the project.

petertodd commented at 5:48 PM on October 13, 2016:

fixed

petertodd force-pushed on Oct 13, 2016
laanwj commented at 5:54 PM on October 13, 2016: member

utACK
btcdrak commented at 8:32 PM on October 13, 2016: contributor

utACK
fanquake commented at 4:21 AM on October 14, 2016: member

utACK
MarcoFalke merged this on Oct 14, 2016
MarcoFalke closed this on Oct 14, 2016
MarcoFalke referenced this in commit 03dd707dc0 on Oct 14, 2016
petertodd deleted the branch on Oct 14, 2016
codablock referenced this in commit 1640aa6f9d on Sep 19, 2017
codablock referenced this in commit 552fafdae6 on Jan 12, 2018
andvgal referenced this in commit bea4fec556 on Jan 6, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels