Eviction logic needs changing #8919

Debug.log extract:-

2016-10-14 00:54:58 Added Inbound connection 52.212.49.168:44235 peer=592579 2016-10-14 00:54:58 receive version message: /bitcoinj:0.12.2/Bitcoin Wallet:2.9.3/: version 70001, blocks=434229, relay=1, services=00000000 us=127.0.0.1:8333, them=52.212.49.168:44235, peer=592579 2016-10-14 00:55:01 Evicting peer 592579 2016-10-14 00:55:01 Added Inbound connection 52.209.80.213:54853 peer=592580 2016-10-14 00:55:01 receive version message: /bitcoinj:0.13.1/Bitsquare:0.3.3/: version 70001, blocks=434229, relay=1, services=00000000 us=127.0.0.1:8333, them=52.209.80.213:54853, peer=592580 2016-10-14 00:55:02 Evicting peer 592580 2016-10-14 00:55:02 Added Inbound connection 52.209.42.124:38681 peer=592581 2016-10-14 00:55:02 receive version message: /BitCoinJ:0.11.2/MultiBit:0.5.18/: version 70001, blocks=434229, relay=1, services=00000000 us=127.0.0.1:8333, them=52.209.42.124:38681, peer=592581 2016-10-14 00:55:03 Evicting peer 592581 2016-10-14 00:55:03 Added Inbound connection 52.18.0.224:46510 peer=592582 2016-10-14 00:55:03 receive version message: /bitcoinj:0.12.2/Bitcoin Wallet:2.9.3/: version 70001, blocks=434229, relay=1, services=00000000 us=127.0.0.1:8333, them=52.18.0.224:46510, peer=592582 2016-10-14 00:55:04 Evicting peer 592582 2016-10-14 00:55:04 Added Inbound connection 127.0.0.1:25336 peer=592583

Unsure of the eviction logic, but surely it is not ideal to disconnect straight away these nodes but instead disconnected older connections thereby giving newer connections some level of service?

The nodes in question are part of the latest round of network DoS attacks. The fact that you selected the new node to disconnect is, indeed, the ideal behavior.

@TheBlueMatt I still think this is an issue. For example, my node has been connected to one of these suspicious nodes now for 2.5 days because it was one of the first nodes to connect to my node upon start up. In the 2.5 days of connection, it has sent a total of 219KB of data...

I am working on code that implements a rating system to nodes based on how useful they are - e.g. the quickest to provide blocks, and also based on how relevant and useful the txs they send are.

This would enable the eviction logic to evict the lowest rated nodes instead of the nodes that most recently tried to connect (as the current behaviour seems to be).

@rebroad did you make any progress on this?