[qa] Send segwit-encoded blocktxn messages in p2p-compactblocks #8922

1. 
   TheBlueMatt commented at 4:55 pm on October 14, 2016: member

   Test with segwit blocktxn messages, since that was missed in #8904, in accordance with the updates to the BIP at https://github.com/bitcoin/bips/pull/462.
2. [qa] Send segwit-encoded blocktxn messages in p2p-compactblocks 032e883b93
3. fanquake added the label Tests on Oct 14, 2016
4. 
   sdaftuar commented at 0:00 am on October 15, 2016: member

   utACK, good catch on the missing test case.

   If you add an additional commit that sets block.nVersion=4 in the build_block_on_tip() function, then I believe this would address the outstanding issue in #8916: #8916 (review)

5. 
   TheBlueMatt commented at 0:10 am on October 15, 2016: member

   Hmm, wasn’t targeting this for backport, though I suppose it doesn’t really matter… I’ll add that commit.

   On October 14, 2016 8:00:43 PM EDT, Suhas Daftuar notifications@github.com wrote:

   utACK, good catch on the missing test case.

   If you add an additional commit that sets block.nVersion=4 in the build_block_on_tip() function, then I believe this would address the outstanding issue in #8916: #8916 (review)

   You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #8922 (comment)

6. [qa] Build v4 blocks in p2p-compactblocktests

   This fixes an issue in backporting to 0.13 as 0.13 enforces SF
   activation by block version lockin instead of through a hard-coded
   block height.

   a4ad37d4ef
7. 
   TheBlueMatt commented at 9:53 pm on October 15, 2016: member

   @sdaftuar ok, that should do it, I believe…I suppose this should get a “Needs Backport” tag now.
8. fanquake added the label Needs backport on Oct 16, 2016
9. 
   btcdrak commented at 8:33 am on October 16, 2016: contributor

   utACK a4ad37d4ef4bcd81bc9d867b277efdebc86bc2e8
10. MarcoFalke added this to the milestone 0.13.1 on Oct 16, 2016
11. 
    MarcoFalke commented at 2:27 pm on October 16, 2016: member

    utACK a4ad37d
12. laanwj merged this on Oct 17, 2016
13. laanwj closed this on Oct 17, 2016

    ---

14. laanwj referenced this in commit 0329511b9c on Oct 17, 2016
15. laanwj removed the label Needs backport on Oct 17, 2016
16. 
    laanwj commented at 11:16 am on October 17, 2016: member

    Backported in #8916
17. DrahtBot locked this on Sep 8, 2021

Contributors
TheBlueMatt sdaftuar btcdrak MarcoFalke laanwj

Labels
Tests

Milestone
0.13.1