Define start and end time for segwit deployment #8937

1. 
   sipa commented at 11:26 am on October 17, 2016: member

   See corresponding mailing list discussion (https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2016-October/013226.html) and BIP update PR (https://github.com/bitcoin/bips/pull/464).
2. fanquake added the label Consensus on Oct 17, 2016
3. Define start and end time for segwit deployment f9c23dea97
4. in src/chainparams.cpp: in 4d31f97daa outdated

   92@@ -93,8 +93,8 @@ class CMainParams : public CChainParams {
   93 
   94         // Deployment of SegWit (BIP141 and BIP143)
   

   ---

   ---

   

   btcdrak commented at 12:07 pm on October 17, 2016:

   also BIP147

   ---

   

   sipa commented at 12:16 pm on October 17, 2016:

   Fixed.
5. sipa force-pushed on Oct 17, 2016
6. laanwj added this to the milestone 0.13.1 on Oct 17, 2016
7. laanwj added the label Needs backport on Oct 17, 2016
8. 
   btcdrak commented at 1:15 pm on October 17, 2016: contributor

   utACK f9c23dea976465c51b9fe2cead81b707678c16bb
9. 
   achow101 commented at 1:20 pm on October 17, 2016: member

   utACK f9c23dea976465c51b9fe2cead81b707678c16bb
10. 
    JornC commented at 1:45 pm on October 17, 2016: none

    Start: http://www.wolframalpha.com/input/?i=unix+1479168000

    12:00:00 am UTC | Tuesday, November 15, 2016

    End: http://www.wolframalpha.com/input/?i=unix+1510704000

    12:00:00 am UTC | Wednesday, November 15, 2017

    utACK f9c23dea976465c51b9fe2cead81b707678c16bb

11. 
    instagibbs commented at 1:54 pm on October 17, 2016: member

    11/15/2016 @ 12:00am (UTC) to 11/15/2017 @ 12:00am (UTC)

    utACK https://github.com/bitcoin/bitcoin/pull/8937/commits/f9c23dea976465c51b9fe2cead81b707678c16bb

12. in src/chainparams.cpp: in f9c23dea97

    90@@ -91,10 +91,10 @@ class CMainParams : public CChainParams {
    91         consensus.vDeployments[Consensus::DEPLOYMENT_CSV].nStartTime = 1462060800; // May 1st, 2016
    92         consensus.vDeployments[Consensus::DEPLOYMENT_CSV].nTimeout = 1493596800; // May 1st, 2017
    93 
    94-        // Deployment of SegWit (BIP141 and BIP143)
    95+        // Deployment of SegWit (BIP141, BIP143, and BIP147)
    

    ---

    ---

    

    paveljanik commented at 1:54 pm on October 17, 2016:

    No need for comma before “and”.

    ---

    

    sipa commented at 1:56 pm on October 17, 2016:

    Depends: https://en.wikipedia.org/wiki/Serial_comma

    ---

    

    instagibbs commented at 1:56 pm on October 17, 2016:

    NACK, Oxford comma for life.

    ---

    

    paveljanik commented at 1:59 pm on October 17, 2016:

    Yes, I’m on the “against” side, sorry.

    ---

    

    paveljanik commented at 2:01 pm on October 17, 2016:

    BIP141, BIP143, BIP147,

    C forever! ;-)

    ---

    

    btcdrak commented at 2:12 pm on October 17, 2016:

    Brit here, I approve of Oxford comma!

    ---

    

    Leviathn commented at 3:59 pm on October 17, 2016:

    Oxford comma is best practice.

    ---

    

    rebroad commented at 5:09 am on November 6, 2016:

    honestly… does it even matter?!
13. in src/chainparams.cpp: in f9c23dea97

    90@@ -91,10 +91,10 @@ class CMainParams : public CChainParams {
    91         consensus.vDeployments[Consensus::DEPLOYMENT_CSV].nStartTime = 1462060800; // May 1st, 2016
    92         consensus.vDeployments[Consensus::DEPLOYMENT_CSV].nTimeout = 1493596800; // May 1st, 2017
    93 
    94-        // Deployment of SegWit (BIP141 and BIP143)
    95+        // Deployment of SegWit (BIP141, BIP143, and BIP147)
    96         consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].bit = 1;
    97-        consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nStartTime = 0;
    98-        consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nTimeout = 0; // Never / undefined
    99+        consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nStartTime = 1479168000; // November 15th, 2016.
    

    ---

    ---

    

    paveljanik commented at 1:56 pm on October 17, 2016:

    No need for dot at the end of the line. This is the third format for simple date we use now (as shown in the Files changed in this PR) :-)

    ---

    

    Xekyo commented at 11:50 pm on October 17, 2016:

    Glory to ISO 8601. Should be 2016-11-15. ;)
14. 
    paveljanik commented at 1:57 pm on October 17, 2016: contributor

    ACK /me too for simple epoch conversion ;-)
15. 
    TheBlueMatt commented at 2:14 pm on October 17, 2016: member

    utACK f9c23dea976465c51b9fe2cead81b707678c16bb
16. 
    jameshilliard commented at 2:23 pm on October 17, 2016: contributor

    utACK https://github.com/bitcoin/bitcoin/commit/f9c23dea976465c51b9fe2cead81b707678c16bb
17. 
    jl2012 commented at 2:30 pm on October 17, 2016: contributor

    utACK f9c23de
18. 
    laanwj commented at 2:33 pm on October 17, 2016: member

    utACK https://github.com/bitcoin/bitcoin/pull/8937/commits/f9c23dea976465c51b9fe2cead81b707678c16bb. Timestamps match those in the BIP update https://github.com/bitcoin/bips/pull/464/commits/5c2da7e07d924c34af4edf7098981c9a376263d2, which matches the UTC dates in the mailing list post. Let’s not hold this up on comment formatting minutia.
19. laanwj merged this on Oct 17, 2016
20. laanwj closed this on Oct 17, 2016

    ---

21. laanwj referenced this in commit c6b959efcf on Oct 17, 2016
22. laanwj referenced this in commit 8b66659921 on Oct 17, 2016
23. laanwj removed the label Needs backport on Oct 17, 2016
24. 
    dcousens commented at 11:24 pm on October 17, 2016: contributor

    utACK 8b66659
25. MarcoFalke locked this on Sep 8, 2021

Contributors
sipa btcdrak achow101 JornC instagibbs paveljanik Leviathn rebroad Xekyo TheBlueMatt jameshilliard jl2012 laanwj dcousens

Labels
Consensus

Milestone
0.13.1