Add missing cs_main lock to ::GETBLOCKTXN processing #8995

pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:2016-10-fix-getblocktxn-locks changing 1 files +2 −0
  1. TheBlueMatt commented at 3:02 AM on October 22, 2016: member

    Note that this is not a major issue as, in order for the missing lock to cause issues, you have to receive a GETBLOCKTXN message while reindexing, adding a block header via RPC, etc, which results in either a table rehash or an insert into the bucket which you are currently looking at.

  2. Add missing cs_main lock to ::GETBLOCKTXN processing
    Note that this is not a major issue as, in order for the missing
    lock to cause issues, you have to receive a GETBLOCKTXN message
    while reindexing, adding a block header via RPC, etc, which results
    in either a table rehash or an insert into the bucket which you are
    currently looking at.
    dfe79060a6
  3. TheBlueMatt force-pushed on Oct 22, 2016
  4. sipa added this to the milestone 0.13.1 on Oct 23, 2016
  5. jonasschnelli added the label P2P on Oct 23, 2016
  6. sipa commented at 5:32 PM on October 23, 2016: member

    utACK dfe79060a62c8de098e75d527d97b99c3b10de50

  7. laanwj added the label Needs backport on Oct 24, 2016
  8. laanwj merged this on Oct 24, 2016
  9. laanwj closed this on Oct 24, 2016

  10. laanwj referenced this in commit ced22d035a on Oct 24, 2016
  11. theuni commented at 4:50 PM on October 24, 2016: member

    post-merge utACK.

  12. laanwj referenced this in commit a587f8af3e on Oct 25, 2016
  13. laanwj referenced this in commit 9ef38758a6 on Oct 27, 2016
  14. gladcow referenced this in commit 117134bac2 on Mar 2, 2018
  15. fanquake removed the label Needs backport on Mar 7, 2018
  16. gladcow referenced this in commit 7ae8f5f80f on Mar 13, 2018
  17. gladcow referenced this in commit 13a47161e6 on Mar 14, 2018
  18. gladcow referenced this in commit 38ee9188c2 on Mar 15, 2018
  19. gladcow referenced this in commit 75850b8a86 on Mar 15, 2018
  20. gladcow referenced this in commit 0488b4c22a on Mar 15, 2018
  21. gladcow referenced this in commit 20915516e2 on Mar 15, 2018
  22. gladcow referenced this in commit a0586eb42a on Mar 24, 2018
  23. gladcow referenced this in commit 8f3f6385f8 on Apr 4, 2018
  24. UdjinM6 referenced this in commit bc45a2f87a on Apr 11, 2018
  25. lateminer referenced this in commit bbc07a86bb on Oct 24, 2018
  26. andvgal referenced this in commit fd5c50bc2b on Jan 6, 2019
  27. CryptoCentric referenced this in commit dd3fd51204 on Feb 28, 2019
  28. DrahtBot locked this on Sep 8, 2021
Labels

Milestone
0.13.1


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me