Make connect=0 disable automatic outbound connections. #9002

pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:connect0 changing 2 files +6 −5

gmaxwell commented at 1:24 AM on October 24, 2016: contributor

Otherwise it just responds to this obvious bit of configuration by trying to connect to "0" in a loop.
luke-jr commented at 4:12 AM on October 24, 2016: member

Concept ACK. I've always used it in this way, might as well make it official.
jonasschnelli added the label P2P on Oct 24, 2016
jonasschnelli commented at 6:12 AM on October 24, 2016: contributor

utACK ec4d35cb501b79173c4fc55a8b4f6c3f97659fe6
laanwj commented at 7:11 AM on October 24, 2016: member

Tested ACK ,needs documentation in HelpMessage though
theuni commented at 4:54 PM on October 24, 2016: member

Concept ACK. Don't we want this to disable dns seed queries too though? As-is, I believe this would actually force them.
laanwj commented at 5:05 PM on October 24, 2016: member

Concept ACK. Don't we want this to disable dns seed queries too though?

I think @gmaxwell checked that
sipa commented at 6:19 PM on October 24, 2016: member

Code review ACK. Agree with documentation update.
MarcoFalke commented at 7:57 PM on October 24, 2016: member

utACK ec4d35c

Not sure if we need to document this. "Normal people" might be fine with just -maxconnections=0 and might not need to know about this?
laanwj commented at 5:37 AM on October 25, 2016: member

Not sure if we need to document this. "Normal people" might be fine with just

I think we should aim to document everything, whether it exists for "normal people" or not. Developers need documentation too. Testers, too. Have you never forgotten about some specific option / combination of options to do a specific thing?

Make connect=0 disable automatic outbound connections.

Otherwise it just responds to this obvious bit of configuration by
 trying to connect to "0" in a loop.

515e2642eb

laanwj commented at 6:46 AM on October 25, 2016: member

Travis failure is unrelated (p2p-compactblocks is having transient issues again), re-spinning
laanwj merged this on Oct 25, 2016
laanwj closed this on Oct 25, 2016
laanwj referenced this in commit e1d1f57b56 on Oct 25, 2016
codablock referenced this in commit b592c27e5f on Sep 19, 2017
codablock referenced this in commit 00f4d887a2 on Jan 13, 2018
zkbot referenced this in commit f1aeaec471 on Mar 21, 2018
andvgal referenced this in commit a338713702 on Jan 6, 2019
CryptoCentric referenced this in commit c7b07fe0e0 on Feb 15, 2019
zkbot referenced this in commit 4fc490c430 on Dec 4, 2019
zkbot referenced this in commit 868c63f92d on Dec 4, 2019
random-zebra referenced this in commit 898bcd24ad on May 20, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels