Rpc boolean consistency #9024

issue gmaxwell opened this issue on October 26, 2016

gmaxwell commented at 11:22 AM on October 26, 2016: contributor

getblock needs a "true" for its verbose argument, while getrawtransaction needs a "1".

all these should be consistent.
jnewbery commented at 12:13 PM on October 26, 2016: member

I agree. This is confusing for users.

I've had a look through the RPCs, and as far as I can tell, getrawtransaction is the only call which takes an int for verbose.

I've opened #9025 to change getrawtransaction to take a bool for verbose. It will still take a num for backward compatibility, but will issue a warning to the user that using a num is deprecated.
fanquake added the label RPC/REST/ZMQ on Oct 27, 2016
laanwj commented at 6:29 AM on October 27, 2016: member

@gmaxwell can you test (and if's what you expect, ACK) #9025?
laanwj renamed this:
~~Rpc boolen consistency~~
Rpc boolean consistency
on Nov 21, 2016
laanwj commented at 6:14 AM on November 23, 2016: member

Closed by #9025.
laanwj closed this on Nov 23, 2016
DrahtBot locked this on Sep 8, 2021

Contributors

Labels