wallet: Change default confirm target from 2 to 6 #9036

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2016_10_txconfirmtarget changing 1 files +1 −1
  1. laanwj commented at 12:19 pm on October 28, 2016: member

    Recent discussion (in IRC meetings, and e.g. #8989) has shown a preference for the default confirm target for smartfees to be 6 instead of 2, to avoid overpaying fees for questionable gain.

    6 is also a compromise between the GUI’s pre-#8989 value of 25 and the bitcoind -txconfirmtarget default of 2. These were unified in #8989, but this has made the (overly expensive) default of 2 as GUI default.

    (needs mention in 0.14 release notes)

  2. wallet: Change default confirm target from 2 to 6
    Recent discussion (in IRC meetings, and e.g. #8989) has shown a
    preference for the default confirm target for smartfees to be 6 instead
    of 2, to avoid overpaying fees for questionable gain.
    
    6 is also a compromise between the GUI's pre-#8989 value of 25 and the
    bitcoind `-txconfirmtarget` default of 2. These were unified in #8989,
    but this has made the (overly expensive) default of 2 as GUI default.
    0fdf810d26
  3. laanwj added the label Wallet on Oct 28, 2016
  4. laanwj added this to the milestone 0.14.0 on Oct 28, 2016
  5. morcos commented at 12:27 pm on October 28, 2016: member
    Thanks. utACK.
  6. jonasschnelli commented at 12:31 pm on October 28, 2016: contributor

    utACK 0fdf810d267928b4c26a2e2cbb8c02b79e7b0ccb. We should think about adding a confirmation-target to fundrawtx, though we could argue that the custom feerate-option (recently added) in conjunction with estimatesmartfee should be sufficient.

    Also, AFAIK, there is no runtime option to change the default confirmation target requiring users using sendto*** RPC calls to restart bitcoind in order to change the confirmation target.

  7. laanwj commented at 12:35 pm on October 28, 2016: member

    Also, AFAIK, there is no runtime option to change the default confirmation target requiring users using sendto*** RPC calls to restart bitcoind in order to change the confirmation target.

    I’m not so happy about RPC calls changing (specific) global defaults. The way -paytxfee and payTxFee is handled has always bothered me. If we’re going to allow changing global configuration parameters there needs to be a generic solution for that. E.g. setoption RPC (there has been work in this direction).

    However there needs to be a way to pass the confirmation target etc. to the RPC sending calls without changing the global default, this would extend the feature set to that of the GUI. E.g. a sendParameters object (which would set fields in the CoinControl structure internally).

  8. jonasschnelli commented at 12:39 pm on October 28, 2016: contributor

    I’m not so happy about RPC calls changing global defaults. The way -paytxfee and payTxFee is handled has always bothered me.

    Yes. A runtime change is probably undesirable. But a per-send custom confirmation target via sendto* could be possible. Though it would be probably the 7 parameter in row after subtractFeeFromAmount (reminds me that we should not forget about #8811).

  9. laanwj commented at 12:40 pm on October 28, 2016: member

    But a per-send custom confirmation target via sendto* could be possible.

    Yes, sendtoadress is a mess (indeed, #8811 with named arguments would help there). fundrawtransaction however already has a parameters object passed in, so this could just be added?

  10. jonasschnelli commented at 12:42 pm on October 28, 2016: contributor

    fundrawtransaction however already has a parameters object passed in, so this could just be added?

    Yes. But somehow it’s already possible:

    0x = estimatesmartfee(<conftarget>)
    1fundrawtransaction <rawtx> '{"feeRate":x}
    
  11. MarcoFalke commented at 1:15 pm on October 28, 2016: member
    utACK 0fdf810
  12. gmaxwell commented at 0:06 am on November 3, 2016: contributor
    utACK.
  13. dcousens commented at 0:59 am on November 3, 2016: contributor
    concept ACK
  14. sipa commented at 6:33 am on November 3, 2016: member
    utACK 0fdf810d267928b4c26a2e2cbb8c02b79e7b0ccb
  15. sipa merged this on Nov 3, 2016
  16. sipa closed this on Nov 3, 2016

  17. sipa referenced this in commit ed0cc50afe on Nov 3, 2016
  18. codablock referenced this in commit 943bf0f60f on Sep 19, 2017
  19. codablock referenced this in commit cd7c5bd75c on Jan 13, 2018
  20. andvgal referenced this in commit b8588300e8 on Jan 6, 2019
  21. CryptoCentric referenced this in commit 331dfed65a on Feb 15, 2019
  22. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me