[0.13 backport] Fix handling of invalid compact blocks #9048

1. 
   sdaftuar commented at 2:46 pm on October 31, 2016: member

   Backport of #9026 to 0.13.
2. [qa] Test that invalid compactblocks don't result in ban 82905069bf
3. fanquake added this to the milestone 0.13.2 on Nov 1, 2016
4. fanquake added the label Backport on Nov 1, 2016
5. 
   sdaftuar commented at 4:52 pm on November 1, 2016: member

   Updated this to match the latest changes in #9026 (see #9026 (comment)).
6. Fix compact block handling to not ban if block is invalid 015865ee9e
7. sdaftuar force-pushed on Nov 1, 2016
8. Bump the protocol version to distinguish new banning behavior.

   This allows future software that would relay compact blocks before
   full validation to announce only to peers that will not ban if the
   block turns out to be invalid.

   e8ef50ba51
9. sdaftuar force-pushed on Nov 1, 2016
10. in src/main.cpp: in e8ef50ba51

    4718@@ -4717,7 +4719,6 @@ std::string GetWarnings(const std::string& strFor)
    4719 
    4720 
    4721 //////////////////////////////////////////////////////////////////////////////
    4722-//
    

    ---

    ---

    

    TheBlueMatt commented at 2:48 pm on November 2, 2016:

    Wut?

    ---

    

    sdaftuar commented at 12:56 pm on November 3, 2016:

    Oops, fixed.
11. 
    TheBlueMatt commented at 3:05 pm on November 2, 2016: member

    utACK e8ef50ba51968da67a36c9fae6938d868b434da2, minus random line removal. Looks equivalent to #9026.
12. laanwj merged this on Nov 9, 2016
13. laanwj closed this on Nov 9, 2016

    ---

14. laanwj referenced this in commit 9460771a60 on Nov 9, 2016
15. DrahtBot locked this on Sep 8, 2021

Contributors
sdaftuar TheBlueMatt

Labels
Backport

Milestone
0.13.2