A slight optimization. Firstly, no need to process cmpctblocks for blocks that have been previously downloaded and pruned. Secondly, no need to lookup the InFlight table until after this check.
Skip processing of cmpctblocks we have previously downloaded. #9055
pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:SkipCmpctblocksPreviouslyDownloaded changing 1 files +6 −5-
rebroad commented at 7:39 AM on November 1, 2016: contributor
-
gmaxwell commented at 7:55 AM on November 1, 2016: contributor
The pindex->nTx test is just one line down from the code you removed.
-
rebroad commented at 3:23 AM on November 2, 2016: contributor
@gmaxwell thank you. will remove the 2nd mention of nTx. I hope you agree that this is a better check than for the HAVE_DATA check, as if the block is so old to have been pruned then we should not be receiving (nor requesting) compact blocks for it.
- rebroad force-pushed on Nov 2, 2016
- laanwj added the label P2P on Nov 2, 2016
-
Skip processing of cmpctblocks we have previously downloaded. d0fb6d46bb
- rebroad force-pushed on Dec 10, 2016
- rebroad closed this on Dec 11, 2016
- MarcoFalke locked this on Sep 8, 2021
