Declare wallet.h functions inline #9071

1. 
   sipa commented at 0:30 am on November 3, 2016: member

   As pointed out by @paveljanik in #9039, the function whose definition is in wallet/wallet.h should be declared inline, and clang warns about this. Do what it says.
2. Declare wallet.h functions inline 2ca882ad41
3. 
   gmaxwell commented at 0:46 am on November 3, 2016: contributor

   Yea, sure. Though I am morally offended by the compiler warning about it. :P (utACK)
4. 
   theuni commented at 3:27 am on November 3, 2016: member

   utACK https://github.com/bitcoin/bitcoin/pull/9071/commits/2ca882ad41f170e705e71766d2b20ea08dbd6a7a.
5. MarcoFalke added the label Refactoring on Nov 3, 2016
6. MarcoFalke added the label Wallet on Nov 3, 2016
7. 
   jonasschnelli commented at 7:26 am on November 3, 2016: contributor

   utACK 2ca882ad41f170e705e71766d2b20ea08dbd6a7a
8. 
   paveljanik commented at 7:49 am on November 3, 2016: contributor

   @gmaxwell I feel offended by the fact that I was not able to find the reason why it was not shown before on the master…

   ACK https://github.com/bitcoin/bitcoin/pull/9071/commits/2ca882ad41f170e705e71766d2b20ea08dbd6a7a

9. 
   MarcoFalke commented at 8:01 am on November 3, 2016: member

   I feel offended because I am not presented this warning even after cherry-picking the commits in #9039
10. 
    paveljanik commented at 8:15 am on November 3, 2016: contributor

    Looks like we have to put some bounty for the solution - 100 tBTC from me for explanation :-)
11. 
    laanwj commented at 9:21 am on November 3, 2016: member

    I’m morally offended by having to merge this obscene change. utACK https://github.com/bitcoin/bitcoin/pull/9071/commits/2ca882ad41f170e705e71766d2b20ea08dbd6a7a
12. laanwj merged this on Nov 3, 2016
13. laanwj closed this on Nov 3, 2016

    ---

14. laanwj referenced this in commit d1871da7fe on Nov 3, 2016
15. codablock referenced this in commit f2911fbfe9 on Sep 19, 2017
16. codablock referenced this in commit 6f8720b7f5 on Jan 13, 2018
17. andvgal referenced this in commit d82214940f on Jan 6, 2019
18. CryptoCentric referenced this in commit 4c37230be2 on Feb 15, 2019
19. CryptoCentric referenced this in commit 899688fa75 on Feb 15, 2019
20. MarcoFalke locked this on Sep 8, 2021

Contributors
sipa gmaxwell theuni jonasschnelli paveljanik MarcoFalke laanwj

Labels
Refactoring Wallet