There was once instance of 'gitian'. I changed it to 'Gitian' so that it would be consistent with all other instances in the file.
Enforcing consistency, 'gitian' to 'Gitian' #9083
pull smatthewenglish wants to merge 1 commits into bitcoin:master from smatthewenglish:patch-9 changing 1 files +1 −1-
smatthewenglish commented at 12:02 PM on November 4, 2016: contributor
-
66ca6cda4c
Enforcing consistency, 'gitian' to 'Gitian'
There was once instance of 'gitian'. I changed it to 'Gitian' so that it would be consistent with all other instances in the file.
- fanquake added the label Docs and Output on Nov 4, 2016
-
paveljanik commented at 6:50 PM on November 4, 2016: contributor
trivial ACK https://github.com/bitcoin/bitcoin/pull/9083/commits/66ca6cda4c67a6c279d086223b69f398dc140724
Please collect such fixes and submit them in one PR e.g. once a month or so.
-
smatthewenglish commented at 7:24 PM on November 4, 2016: contributor
I know what you mean. At the moment I'm trying to understand how the code works so I'm reading through all the comments, if I see something like that then I just quickly fix it and create a pull request so that I don't forget about it.
-
paveljanik commented at 7:33 PM on November 4, 2016: contributor
And you can as well collect your fixes in some of your branches (so you do not forget about it) and then PR it at the end of month :-)
-
smatthewenglish commented at 7:36 PM on November 4, 2016: contributor
yeah, that makes sense. I'll do that. this is the first open source project I've contributed to so- I'm still kind of getting the hang of things.
What do you think of my PR #9064?
-
fanquake commented at 6:33 AM on November 5, 2016: member
ACK 66ca6cd
-
Leviathn commented at 9:18 PM on November 5, 2016: none
Ack
- MarcoFalke merged this on Nov 7, 2016
- MarcoFalke closed this on Nov 7, 2016
- MarcoFalke referenced this in commit 2b799ae9e1 on Nov 7, 2016
-
MarcoFalke commented at 11:56 AM on November 7, 2016: member
Agree with @paveljanik. Please try to collect small fixes in separate commits/branches and then submit them in one pull request, rather than a separate commit/pull request for each single word typo-fix.
-
smatthewenglish commented at 12:30 PM on November 7, 2016: contributor
please forgive me if I was making too many pull requests for those small errors
in fact already I've been accumulating a new patch, maybe I'll make it into a pull request at the end of the month or so?
-
MarcoFalke commented at 12:41 PM on November 7, 2016: member
@s-matthew-english Sounds good!
-
MarcoFalke commented at 8:29 PM on November 7, 2016: member
@s-matthew-english If you are looking for other fixes, there are still some like this.
-
smatthewenglish commented at 12:45 AM on November 13, 2016: contributor
@MarcoFalke ah- thank you for pointing that out :)
Please forgive me is this is daft, but I'm having trouble determining what is exactly the change that needs fixing.
Is it to ensure that calls to the help command output this:
s/waitforblock/waitforblock <blockhash> <timeout>? -
paveljanik commented at 9:08 AM on November 13, 2016: contributor
-
smatthewenglish commented at 6:15 PM on November 21, 2016: contributor
so then- I guess I can find all those instances by grepping for
grep -rl 'request.fHelp' .and then I should make sure that they all output ass/waitforblock/waitforblock <blockhash> <timeout>, is it right? - codablock referenced this in commit 47a7ec79fe on Jan 13, 2018
- andvgal referenced this in commit efebe42332 on Jan 6, 2019
- MarcoFalke locked this on Sep 8, 2021
Labels