Reduce ambiguity of warning message #9088

1. 
   rebroad commented at 7:20 am on November 5, 2016: contributor

   Fixes #9079
2. fanquake added the label GUI on Nov 5, 2016
3. 
   kazcw commented at 5:20 pm on November 5, 2016: contributor

   This helps a lot with the ambiguity, but users who have already seen the message will tend to read just the beginning, so I think it should start with a summary of the situation as the old message (sort of) did. What about phrasing the first sentence more like “Your wallet is not finished synchronizing with the bitcoin network.” to lead with status information rather than exposition.
4. 
   MarcoFalke commented at 5:34 pm on November 5, 2016: member

   Thanks! Concept ACK.
5. 
   jonasschnelli commented at 9:22 pm on November 5, 2016: contributor

   Thanks! ACK 26f2cb1c9c739002ea74afbb7b333f794c2d7cfd
6. 
   fanquake commented at 3:44 am on November 6, 2016: member

   ACK 26f2cb1
7. 
   rebroad commented at 7:37 am on November 6, 2016: contributor

   @kazcw I see your point. I have rearranged the message now to put the more pertinent information first. @jonasschnelli @fanquake Are your previous ACKs valid for this new wording?
8. rebroad force-pushed on Nov 6, 2016
9. rebroad force-pushed on Nov 6, 2016
10. Make warning message about wallet balance possibly

    being incorrect less ambiguous.
    
    Fixes #9079

    77cbbd9ecf
11. rebroad force-pushed on Nov 6, 2016
12. 
    MarcoFalke commented at 9:11 am on November 6, 2016: member

    utACK 77cbbd9
13. 
    rebroad commented at 9:35 am on November 6, 2016: contributor

    Why is travis complaining?
14. 
    laanwj commented at 9:39 am on November 7, 2016: member

    Unrelated, likely (issue #8842):

    0p2p-segwit.py                  | False  | 74 s
    

15. 
    laanwj commented at 10:00 am on November 8, 2016: member

    utACK 77cbbd9

    This helps a lot with the ambiguity, but users who have already seen the message will tend to read just the beginning

    Luckily there will not be many users that have already seen the message, as it’s not in any release yet.

16. laanwj merged this on Nov 8, 2016
17. laanwj closed this on Nov 8, 2016

    ---

18. laanwj referenced this in commit 4e5782438c on Nov 8, 2016
19. codablock referenced this in commit ba6bf73321 on Sep 8, 2017
20. UdjinM6 referenced this in commit 9707ca5cea on Sep 9, 2017
21. DrahtBot locked this on Sep 8, 2021

Contributors
rebroad kazcw MarcoFalke jonasschnelli fanquake laanwj

Labels
GUI