fee estimation: UNLIKELY_PCT is declared but never used #9104

issue dooglus opened this issue on November 8, 2016

dooglus commented at 7:44 PM on November 8, 2016: contributor

#7730 removed priority estimation and so the declaration of UNLIKELY_PCT can now be removed.

Similarly TxConfirmStats::EstimateMedianVal() is now only called with requireGreater set to true, so that function argument can be removed, along with the logic which depends on its value.

I can submit a pull request for this if it's something that would be useful.
MarcoFalke added the label Refactoring on Nov 8, 2016
laanwj commented at 8:55 PM on November 9, 2016: member

Fixed by #9111
laanwj closed this on Nov 9, 2016
dooglus commented at 8:57 PM on November 9, 2016: contributor

#9111 doesn't fix this:

Similarly TxConfirmStats::EstimateMedianVal() is now only called with requireGreater set to true, so that function argument can be removed, along with the logic which depends on its value.
laanwj commented at 8:58 PM on November 9, 2016: member

Ok, why not just file a patch to remove those then.
dooglus commented at 9:08 PM on November 9, 2016: contributor

OK, done. (#9118)
laanwj commented at 9:40 PM on November 9, 2016: member

Sorry for making you do this, we should have discussed with @morcos first.
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels