TxConfirmStats::EstimateMedianVal() is only ever called with requireGreater set to true so that function argument can be removed, along with the logic which depends on its value.
Remove requireGreater argment from TxConfirmStats::EstimateMedianVal() #9118
pull dooglus wants to merge 1 commits into bitcoin:master from dooglus:remove-dead-code changing 2 files +17 −24-
dooglus commented at 9:07 PM on November 9, 2016: contributor
-
df9b2bb97d
Remove requireGreater argment from TxConfirmStats::EstimateMedianVal()
TxConfirmStats::EstimateMedianVal() is only ever called with requireGreater set to true so that function argument can be removed, along with the logic which depends on its value.
- laanwj added the label Mempool on Nov 9, 2016
- MarcoFalke added the label TX fees and policy on Nov 9, 2016
- MarcoFalke removed the label Mempool on Nov 9, 2016
-
MarcoFalke commented at 9:19 PM on November 9, 2016: member
Concept ACK on removing dead code when it is no longer used, but you might want to check with @morcos to make sure there is no use of that logic in the future.
- MarcoFalke added the label Refactoring on Nov 9, 2016
-
morcos commented at 9:20 PM on November 9, 2016: member
NACK
This only became dead code 2 days ago. It was tricky to get right the first time, and I'd like to see a compelling argument why this functionality wouldn't be necessary in future improvements to fee estimation before we remove it.
I agree that if it stays unused, it should eventually be removed as the code is harder to understand with it, but I see no harm in leaving it around for a release or two until we see if there are further changes to fee estimation happening.
-
laanwj commented at 9:27 PM on November 9, 2016: member
Closing, agree that there is no rush to remove this. I didn't realize that this only became unused two days ago.
- laanwj closed this on Nov 9, 2016
- DrahtBot locked this on Sep 8, 2021
