Missed one "return false" in recent refactoring in #9067 which means that AppInitRawTx returns 0 in that case i.e. EXIT_SUCCESS which is wrong.
Sorry 😞
bug: Missed one "return false" in recent refactoring in #9067 #9120
pull UdjinM6 wants to merge 1 commits into bitcoin:master from UdjinM6:fixExitCodesBitcoinTx changing 1 files +1 −1-
UdjinM6 commented at 10:04 PM on November 9, 2016: contributor
-
Missed one "return false" in recent refactoring in #9067 45d372f889
- MarcoFalke added the label Refactoring on Nov 9, 2016
-
jonasschnelli commented at 7:28 AM on November 10, 2016: contributor
Thanks for fixing this up. utACK 45d372f88900bda74835a20a44246746c2ac94e6
-
fanquake commented at 8:38 AM on November 10, 2016: member
utACK 45d372f
-
paveljanik commented at 8:39 AM on November 10, 2016: contributor
-
laanwj commented at 9:31 AM on November 10, 2016: member
If only we had a test for this :) utACK
- laanwj merged this on Nov 10, 2016
- laanwj closed this on Nov 10, 2016
- laanwj referenced this in commit 537e0cb252 on Nov 10, 2016
- luke-jr referenced this in commit 08d1c90113 on Dec 2, 2016
- sickpig referenced this in commit 50b8c06272 on Mar 31, 2017
- lateminer referenced this in commit 4039e1c019 on Oct 16, 2018
- DrahtBot locked this on Sep 8, 2021
