As requested by @jonasschnelli at #8996 (comment), add a tooltip:
<img width="304" alt="screen shot 2016-11-11 at 11 56 11" src="https://cloud.githubusercontent.com/assets/6848764/20213011/86c18000-a806-11e6-8009-cfbe647f8d3a.png">
<img width="312" alt="screen shot 2016-11-11 at 11 56 17" src="https://cloud.githubusercontent.com/assets/6848764/20213010/868f63b8-a806-11e6-818c-e5cb3956a2e9.png">
".<br>" to save translators work... But ugly 8)
Nice! utACK 45e0dcab570667c7d7d3476aaaebf7d094874fd1
I think the standalone "." is okay.
s/Press/Click/?
utACK 45e0dcab570667c7d7d3476aaaebf7d094874fd1. What happens if you replace the br with a single space?
@luke-jr Click, because it is not a button. Yes. Changed. @MarcoFalke Without br, the tooltip is three lines long and the break is in the middle of a sentence. It looked really bad thus I have copied the solution used for other long tooltips. First line is info, second line is the help what to do next/description.
718 | if (clientModel->getNetworkActive()) {
719 | - connectionsControl->setToolTip(tr("%n active connection(s) to Bitcoin network", "", count));
720 | + tooltip = tr("%n active connection(s) to Bitcoin network", "", count) + QString(".<br>") + tr("Click to disable network activity.");
721 | } else {
722 | - connectionsControl->setToolTip(tr("Network activity disabled"));
723 | + tooltip = tr("Network activity disabled") + QString(".<br>") + tr("Click to enable network activity again.");
I believe this is a new string, so prefer to put the period in the translation. (keep the <br> outside however)
@luke-jr Pardon? What is a new string?
"Network activity disabled" has not been in any Core releases yet.
@luke-jr Right! So this can be even more nicer. Will do in an hour or so.
Ready for review.
utACK 1260c1103bf3f5d6b4a9109949346ef4568a9c60
utACK 1260c11
@jonasschnelli Does anyone else think its a bit too easy to actually turn off your whole network. I think this tooltip will help a bit, but it seems a pretty benign thing to just click on that little network symbol and you don't realize you're disconnecting yourself from the network. Would it be better (or possible) to give you a little drop down or a confirmation or something? @sdaftuar?
@morcos: No strong opinion. Maybe a confirmation dialog could make sense. Though, maybe only at the first time, otherwise this will annoy experience users. At the moment, the feature is relatively hidden.
Agree that the feature is hidden. Also, I think we don't need to prevent accidental disconnects, as the cross mark is shown clearly, so the user can figure out what happened pretty fast.
What about making cross mark red?
Just as a data point -- I was surprised by this behavior a couple days ago when I clicked on that network icon (before this tooltip was added) and unexpectedly disconnected from the network. I thought it was surprising that of the 4 icons in the bottom corner, 2 of them can be clicked on to do something while 2 don't do anything, and of those that do something, 1 gives a dropdown (the one for changing units) while 1 just does something immediately (disconnect the network).
Maybe we should at a warning bar at the top, similar to the "prerelease software" one, that says "You are currently disconnected from the network, click [here] or on the network icon in the status bar to re-enable"?
Three ideas were mentioned before:
slide overlay (as in initial sync phase)
confirm first "Disable network" click
make cross red
Maybe clicking the icon should give a context menu with disconnect and network settings (open the options dialog to the right tab)?