Mention the new network toggle functionality in the tooltip. #9130

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:20161111_disable_network_tooltip changing 1 files +8 −2
  1. paveljanik commented at 11:01 AM on November 11, 2016: contributor

    As requested by @jonasschnelli at #8996 (comment), add a tooltip:

    <img width="304" alt="screen shot 2016-11-11 at 11 56 11" src="https://cloud.githubusercontent.com/assets/6848764/20213011/86c18000-a806-11e6-8009-cfbe647f8d3a.png">

    <img width="312" alt="screen shot 2016-11-11 at 11 56 17" src="https://cloud.githubusercontent.com/assets/6848764/20213010/868f63b8-a806-11e6-818c-e5cb3956a2e9.png">

  2. paveljanik commented at 11:03 AM on November 11, 2016: contributor

    ".<br>" to save translators work... But ugly 8)

  3. fanquake added the label GUI on Nov 11, 2016
  4. jonasschnelli commented at 11:11 AM on November 11, 2016: contributor

    Nice! utACK 45e0dcab570667c7d7d3476aaaebf7d094874fd1

    I think the standalone "." is okay.

  5. luke-jr commented at 11:25 AM on November 11, 2016: member

    s/Press/Click/?

  6. MarcoFalke commented at 11:27 AM on November 11, 2016: member

    utACK 45e0dcab570667c7d7d3476aaaebf7d094874fd1. What happens if you replace the br with a single space?

  7. paveljanik commented at 7:58 PM on November 11, 2016: contributor

    @luke-jr Click, because it is not a button. Yes. Changed. @MarcoFalke Without br, the tooltip is three lines long and the break is in the middle of a sentence. It looked really bad thus I have copied the solution used for other long tooltips. First line is info, second line is the help what to do next/description.

  8. paveljanik force-pushed on Nov 11, 2016
  9. in src/qt/bitcoingui.cpp:None in 374c4fb1af outdated
     718 |      if (clientModel->getNetworkActive()) {
     719 | -        connectionsControl->setToolTip(tr("%n active connection(s) to Bitcoin network", "", count));
     720 | +        tooltip = tr("%n active connection(s) to Bitcoin network", "", count) + QString(".<br>") + tr("Click to disable network activity.");
     721 |      } else {
     722 | -        connectionsControl->setToolTip(tr("Network activity disabled"));
     723 | +        tooltip = tr("Network activity disabled") + QString(".<br>") + tr("Click to enable network activity again.");
    


    luke-jr commented at 1:22 AM on November 12, 2016:

    I believe this is a new string, so prefer to put the period in the translation. (keep the &lt;br> outside however)


    paveljanik commented at 6:57 AM on November 12, 2016:

    @luke-jr Pardon? What is a new string?


    luke-jr commented at 7:22 AM on November 12, 2016:

    "Network activity disabled" has not been in any Core releases yet.

  10. paveljanik commented at 12:12 PM on November 12, 2016: contributor

    @luke-jr Right! So this can be even more nicer. Will do in an hour or so.

  11. Mention the new network toggle functionality in the tooltip. 1260c1103b
  12. paveljanik force-pushed on Nov 12, 2016
  13. paveljanik commented at 11:36 AM on November 17, 2016: contributor

    Ready for review.

  14. MarcoFalke commented at 11:41 PM on November 17, 2016: member

    utACK 1260c1103bf3f5d6b4a9109949346ef4568a9c60

  15. fanquake commented at 3:37 AM on November 18, 2016: member

    utACK 1260c11

  16. MarcoFalke assigned jonasschnelli on Nov 18, 2016
  17. jonasschnelli merged this on Nov 22, 2016
  18. jonasschnelli closed this on Nov 22, 2016

  19. jonasschnelli referenced this in commit ac489b2445 on Nov 22, 2016
  20. morcos commented at 2:42 PM on November 22, 2016: member

    @jonasschnelli Does anyone else think its a bit too easy to actually turn off your whole network. I think this tooltip will help a bit, but it seems a pretty benign thing to just click on that little network symbol and you don't realize you're disconnecting yourself from the network. Would it be better (or possible) to give you a little drop down or a confirmation or something? @sdaftuar?

  21. jonasschnelli commented at 3:49 PM on November 22, 2016: contributor

    @morcos: No strong opinion. Maybe a confirmation dialog could make sense. Though, maybe only at the first time, otherwise this will annoy experience users. At the moment, the feature is relatively hidden.

  22. MarcoFalke commented at 6:13 PM on November 22, 2016: member

    Agree that the feature is hidden. Also, I think we don't need to prevent accidental disconnects, as the cross mark is shown clearly, so the user can figure out what happened pretty fast.

  23. paveljanik commented at 2:43 PM on November 23, 2016: contributor

    What about making cross mark red?

  24. sdaftuar commented at 5:11 PM on November 23, 2016: member

    Just as a data point -- I was surprised by this behavior a couple days ago when I clicked on that network icon (before this tooltip was added) and unexpectedly disconnected from the network. I thought it was surprising that of the 4 icons in the bottom corner, 2 of them can be clicked on to do something while 2 don't do anything, and of those that do something, 1 gives a dropdown (the one for changing units) while 1 just does something immediately (disconnect the network).

  25. sipa commented at 5:17 PM on November 23, 2016: member

    Maybe we should at a warning bar at the top, similar to the "prerelease software" one, that says "You are currently disconnected from the network, click [here] or on the network icon in the status bar to re-enable"?

  26. paveljanik commented at 5:22 PM on November 23, 2016: contributor

    Three ideas were mentioned before:

    • slide overlay (as in initial sync phase)

    • confirm first "Disable network" click

    • make cross red

  27. luke-jr commented at 9:05 PM on November 23, 2016: member

    Maybe clicking the icon should give a context menu with disconnect and network settings (open the options dialog to the right tab)?

  28. luke-jr referenced this in commit b26febe97d on Dec 21, 2016
  29. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me