Unset fImporting for loading mempool #9133

pull morcos wants to merge 1 commits into bitcoin:master from morcos:noImportLoadMempool changing 1 files +3 −1
  1. morcos commented at 3:05 PM on November 11, 2016: member

    LoadMempool happens in the import thread which has fImporting set to true. This will cause the node to think its in IBD until the mempool is fully loaded. This isn't necessary and can interfere with initial syncing. It also breaks at least the pruning.py test.

    I can't think of any reason to want IBD to be set while loading the mempool except for the possible effect on fee estimation. If you had a mempool dump which was in the future from your chainstate then this might lead to a detrimental effect on fee estimation, but this seems unlikely and should be fixed in another way..

  2. Unset fImporting for loading mempool 79f755db41
  3. fanquake added the label Mempool on Nov 12, 2016
  4. sipa commented at 11:22 PM on November 15, 2016: member

    utACK 79f755db4114ad25c6f856c9a07e7101f2044af3

  5. dcousens approved
  6. gmaxwell commented at 12:28 AM on November 16, 2016: contributor

    utACK (I hesitated due to the lack of indent, but Sipa pointed out to me that we do it elsewhere.)

  7. laanwj merged this on Nov 16, 2016
  8. laanwj closed this on Nov 16, 2016

  9. laanwj referenced this in commit 434e683f7b on Nov 16, 2016
  10. codablock referenced this in commit 9b9d3d1da8 on Jan 15, 2018
  11. andvgal referenced this in commit 6c3227088d on Jan 6, 2019
  12. CryptoCentric referenced this in commit 2ae9a7005b on Feb 24, 2019
  13. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 12:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me