Add compile and link options echo to configure #9156

Adds some compile and link options output to the configure process. Maybe I'm old school, but I like this level of verbosity.

Results in something like

[ ---snip--- ]
configure: Using bignum implementation: no
configure: Using scalar implementation: 64bit
configure: Using endomorphism optimizations: no
configure: Building ECDH module: no
configure: Building Schnorr signatures module: no
configure: Building ECDSA pubkey recovery module: yes
configure: Using jni: no
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating libsecp256k1.pc
config.status: creating src/libsecp256k1-config.h
config.status: executing depfiles commands
config.status: executing libtool commands

Options used to compile and link:
  WITH WALLET   = yes
  WITH GUI / QT = yes
   WITH QR      = yes
  WITH TEST     = no
  WITH BENCH    = yes

  TARGET OS     = darwin
  BUILD OS      = darwin

  CC            = /usr/local/bin/ccache gcc
  CFLAGS        = -g -O2
  CPPFLAGS      = -Qunused-arguments  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -I/usr/local/opt/berkeley-db4/include -DMAC_OSX
  CXX           = /usr/local/bin/ccache g++ -std=c++11
  CXXFLAGS      = -g -O2 -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -Wno-self-assign -Wno-unused-local-typedef -Wno-deprecated-register
  LDFLAGS       =  -Wl,-headerpad_max_install_names -Wl,-dead_strip

What's with all the uppercase? Probably should specify which version of Qt.

Concept ACK

utACK 9d380ea

@theuni can you take a look as well?

Can you add ZMQ and miniupnpc co make it complete?

Concept ACK!

I like such verbosity, because it can the be used to compare build logs easily (it is no fun to look for differences on 500characters configure lines)....

Updated, added major Qt version, ZMQ, UPNP, DEBUG ENABLED (more obvious then checking for -O0). QR CODE and QT VERSION is only visible when QT is enabled.

This is how it looks now:

Options used to compile and link:
  WITH WALLET   = yes
  WITH GUI / QT = yes
    QT VERSION  = 5
    WITH QR     = yes
  WITH ZMQ      = yes
  WITH TEST     = yes
  WITH BENCH    = yes
  WITH UPNP     = yes
  DEBUG ENABLED = no

  TARGET OS     = darwin
  BUILD OS      = darwin

  CC            = /usr/local/bin/ccache gcc
  CFLAGS        = -g -O2
  CPPFLAGS      = -Qunused-arguments  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -I/usr/local/opt/berkeley-db4/include -DMAC_OSX
  CXX           = /usr/local/bin/ccache g++ -std=c++11
  CXXFLAGS      = -g -O2 -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -Wno-self-assign -Wno-unused-local-typedef -Wno-deprecated-register
  LDFLAGS       =  -Wl,-headerpad_max_install_names -Wl,-dead_strip

utACK ce1acfc6e9fb6e81c11f3d65446999462206eae6

There are too many uppercase words WITH. I think that only variable names (CC, CFLAGS, ..., LDFLAGS) should be uppercased.

Very nice, concept ACK. Will review. Edit: Well that's simple enough. utACK https://github.com/bitcoin/bitcoin/commit/ce1acfc6e9fb6e81c11f3d65446999462206eae6.

For bikeshedding, I agree with @paveljanik about not using caps except for variables that can be overridden. But it's not a big deal.

There are too many uppercase words WITH. I think that only variable names (CC, CFLAGS, ..., LDFLAGS) should be uppercased.

I tend to agree. Not that I care much for aesthetic reasons, but it can result in confusion, in the ./configure --help interface uppercase means 'a variable that can be overridden'. So yes let's make it less yelly :-)

Switched the non CFLAGish stuff to lowercase:

This is how it looks now:

Options used to compile and link:
  with wallet   = yes
  with gui / qt = yes
    qt version  = 5
    with qr     = yes
  with zmq      = yes
  with test     = yes
  with bench    = yes
  with upnp     = yes
  debug enabled = no

  target os     = darwin
  build os      = darwin

  CC            = /usr/local/bin/ccache gcc
  CFLAGS        = -g -O2
  CPPFLAGS      = -Qunused-arguments  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -I/usr/local/opt/berkeley-db4/include -DMAC_OSX
  CXX           = /usr/local/bin/ccache g++ -std=c++11
  CXXFLAGS      = -g -O2 -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -Wno-self-assign -Wno-unused-local-typedef -Wno-deprecated-register
  LDFLAGS       =  -Wl,-headerpad_max_install_names -Wl,-dead_strip

Travis errors are unrelated. Output looks ok.

config.status: executing libtool commands

Options used to compile and link:
  with wallet   = yes
  with gui / qt = yes
    qt version  = 5
    with qr     = yes
  with zmq      = yes
  with test     = yes
  with bench    = yes
  with upnp     = yes
  debug enabled = no

  target os     = darwin
  build os      = darwin

  CC            = gcc
  CFLAGS        = -g -O2
  CPPFLAGS      =  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -I/usr/local/opt/berkeley-db4/include -DMAC_OSX
  CXX           = g++ -std=c++11
  CXXFLAGS      = -g -O2 -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -Wno-self-assign -Wno-unused-local-typedef -Wno-deprecated-register
  LDFLAGS       =  -Wl,-headerpad_max_install_names -Wl,-dead_strip

ACK https://github.com/bitcoin/bitcoin/pull/9156/commits/d8274bcd00865d829808e8e05651c61dff7ccac0