Change check_announcement_of_new_block() to wait specifically for the announcement of the newly created block, instead of waiting for any announcement. A difficult to reproduce failure in check_announcement_of_new_block() that happened in a travis build (https://travis-ci.org/bitcoin/bitcoin/jobs/175198367) might have happened because an older announcement was mistaken for the expected one.
[qa] Wait for specific block announcement in p2p-compactblocks #9159
pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:cmpct-announce-wait changing 1 files +6 −3-
ryanofsky commented at 7:00 PM on November 14, 2016: member
-
dfa44d1b07
[qa] Wait for specific block announcement in p2p-compactblocks
Change check_announcement_of_new_block() to wait specifically for the announcement of the newly created block, instead of waiting for any announcement at all. A difficult to reproduce failure in check_announcement_of_new_block() that happened in a travis build (https://travis-ci.org/bitcoin/bitcoin/jobs/175198367) might have happened because an older announcement was mistaken for the expected one. The error looked like: Assertion failed: Failed File ".../bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 145, in main self.run_test() File ".../bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 787, in run_test self.test_sendcmpct(self.nodes[1], self.segwit_node, 2, old_node=self.old_node) File ".../bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 201, in test_sendcmpct check_announcement_of_new_block(node, test_node, lambda p: p.last_cmpctblock is None and p.last_inv is not None) File ".../bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 194, in check_announcement_of_new_block assert(predicate(peer)) This commit also changes the assertion failed message above to include more detailed information for debug. - fanquake added the label Tests on Nov 15, 2016
-
MarcoFalke commented at 10:43 PM on November 17, 2016: member
utACK dfa44d1b07a6d1022005dba63dd6372739eee8a0
- MarcoFalke merged this on Nov 19, 2016
- MarcoFalke closed this on Nov 19, 2016
- MarcoFalke referenced this in commit 44adf683ad on Nov 19, 2016
- MarcoFalke referenced this in commit eca9b46537 on Nov 19, 2016
- gladcow referenced this in commit e5566d1f00 on Mar 5, 2018
- gladcow referenced this in commit 745ff7841c on Mar 13, 2018
- gladcow referenced this in commit ea66fbe1ef on Mar 14, 2018
- gladcow referenced this in commit 8833cf053f on Mar 15, 2018
- gladcow referenced this in commit 71fe2cf1c5 on Mar 15, 2018
- gladcow referenced this in commit b65e2d5dc9 on Mar 15, 2018
- gladcow referenced this in commit fade6a1730 on Mar 15, 2018
- gladcow referenced this in commit bc55d06501 on Mar 24, 2018
- gladcow referenced this in commit 629ddc3d24 on Apr 4, 2018
- UdjinM6 referenced this in commit bc45a2f87a on Apr 11, 2018
- andvgal referenced this in commit fd5c50bc2b on Jan 6, 2019
- CryptoCentric referenced this in commit dd3fd51204 on Feb 28, 2019
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels