build: fix qt5.7 build under macOS #9169

1. 
   theuni commented at 9:14 PM on November 15, 2016: member

   Fixes #8237

   OBJCXX's std flags don't get defined by our cxx macro. Rather than hard-coding to c++11, just force OBJCXX to be the same as CXX unless the user specified otherwise.

   Untested with qt 5.7, so it'd be helpful if @fanquake or @morcos could confirm that this actually fixes before merging.

2. build: fix qt5.7 build under macOS

   OBJCXX's std flags don't get defined by our cxx macro. Rather than hard-coding
   to c++11, just force OBJCXX to be the same as CXX unless the user specified
   otherwise.

   70266e9829
3. 
   morcos commented at 9:22 PM on November 15, 2016: member

   this appears to work for me thanks!

4. 
   droark commented at 9:51 PM on November 15, 2016: contributor

   tACK

   Compiled using Xcode 8.1 under macOS 10.12.1 and a brewed Qt 5.7. Compiled cleanly, other than some unrelated deprecation warnings and some third-party code that's not totally clean.

5. fanquake added the label Build system on Nov 16, 2016
6. 
   fanquake commented at 2:04 AM on November 16, 2016: member

   Tested ACK https://github.com/bitcoin/bitcoin/pull/9169/commits/70266e98292bf9c8f019ca4b11d681b575f71448

7. laanwj merged this on Nov 16, 2016
8. laanwj closed this on Nov 16, 2016

   ---

9. laanwj referenced this in commit 918ea16dc0 on Nov 16, 2016
10. 
    MarcoFalke commented at 9:59 AM on November 16, 2016: member

    Is this a bug fix, that needs backport?

11. laanwj added this to the milestone 0.13.2 on Nov 16, 2016
12. laanwj added the label Needs backport on Nov 16, 2016
13. 
    laanwj commented at 1:15 PM on November 16, 2016: member

    Yes I think so

14. laanwj referenced this in commit 9cebdb016d on Dec 2, 2016
15. 
    laanwj commented at 7:22 AM on December 2, 2016: member

    Backported in #9264, removing tag.

16. laanwj removed the label Needs backport on Dec 2, 2016
17. laanwj referenced this in commit d1b4da9259 on Dec 2, 2016
18. sickpig referenced this in commit 72bff1a631 on Feb 28, 2017
19. gandrewstone referenced this in commit 1d56e4c72c on Mar 1, 2017
20. jtimon referenced this in commit 5fe46c8576 on Apr 20, 2017
21. UdjinM6 referenced this in commit 10b9bba94d on May 9, 2017
22. nextux referenced this in commit 5bbba2fb88 on Jun 10, 2019
23. MarcoFalke locked this on Sep 8, 2021

Milestone
0.13.2