Clarify CreateTransaction error messages #9204

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:nonneg changing 1 files +3 −3

instagibbs commented at 6:21 PM on November 22, 2016: member

Logic change removing nValue check is fine since value won't be negative, and thus can give a better error.

in src/wallet/wallet.cpp:None in 54f2b12b8d outdated

2335 |                              else
2336 | -                                strFailReason = _("The transaction amount is too small to send after the fee has been deducted");
2337 | +                                strFailReason = _("The transaction output amount is too small to send after the fee has been deducted");
2338 |                          }
2339 |                          else
2340 |                              strFailReason = _("Transaction amount too small");

morcos commented at 6:35 PM on November 22, 2016:

Do you want to include this line too? Not sure it's worth changing these, but if you are going to, perhaps you could be even more clear "One of the transaction output amounts .." or similar

instagibbs commented at 6:40 PM on November 22, 2016:

you're right not important, thought I changed it back

instagibbs force-pushed on Nov 22, 2016
fix CreateTransaction error messages 918b126901
instagibbs force-pushed on Nov 22, 2016
sipa commented at 10:19 PM on November 22, 2016: member

utACK
fanquake added the label Docs and Output on Nov 23, 2016
laanwj commented at 6:16 AM on November 23, 2016: member

utACK https://github.com/bitcoin/bitcoin/pull/9204/commits/918b126901d6fd76f8ec49fce69a60d7819d3a57
fanquake commented at 6:36 AM on November 23, 2016: member

utACK 918b126
jonasschnelli commented at 7:24 AM on November 23, 2016: contributor

trivial utACK 918b126901d6fd76f8ec49fce69a60d7819d3a57
laanwj merged this on Nov 23, 2016
laanwj closed this on Nov 23, 2016
laanwj referenced this in commit 74ced54b7e on Nov 23, 2016
codablock referenced this in commit 898bd4395d on Jan 15, 2018
andvgal referenced this in commit 1ee9c216a0 on Jan 6, 2019
CryptoCentric referenced this in commit d9b405922d on Feb 24, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels