[Doc] Move comments above bash command in build-unix #9207

pull AmirAbrams wants to merge 1 commits into bitcoin:master from AmirAbrams:patch-2 changing 1 files +4 −4

AmirAbrams commented at 7:52 AM on November 23, 2016: contributor
For most it is obvious that you need to remove the comments or add the # in front but without it, I get this error:
```
dev@linuxdev-vm:~$ sudo apt-get install libzmq3-dev (provides ZMQ API 4.x)
bash: syntax error near unexpected token `('
```
fanquake added the label Docs and Output on Nov 23, 2016
[Doc] Move comments above bash command 69bc8e7967
in doc/build-unix.md:None in 27f238cac0 outdated
```
  97 | @@ -98,11 +98,11 @@ See the section "Disable-wallet mode" to build Bitcoin Core without wallet.
  98 |  
  99 |  Optional:
 100 |  
 101 | -    sudo apt-get install libminiupnpc-dev (see --with-miniupnpc and --enable-upnp-default)
 102 | +    sudo apt-get install libminiupnpc-dev # (see --with-miniupnpc and --enable-upnp-default)
```
laanwj commented at 7:56 AM on November 23, 2016:

Alternatively this (...) could go after Optional in the previous line. The less to copy/paste the better I'd say, and comments don't really make that much sense here. (same below)

AmirAbrams commented at 8:00 AM on November 23, 2016:

Okay, I will move the comments above the code.
AmirAbrams renamed this:
~~[Doc] Add missing bash # comment characters~~
[Doc] Move comments above bash command in build-unix
on Nov 23, 2016
jonasschnelli commented at 8:25 AM on November 23, 2016: contributor

ACK 69bc8e79676a0bde3e1b28da8cdd832842ff18bc
AmirAbrams commented at 8:26 AM on November 23, 2016: contributor

@laanwj, I moved the comments above as requested and squashed my commit.
fanquake commented at 8:31 AM on November 23, 2016: member

utACK 69bc8e7
paveljanik commented at 9:15 AM on November 23, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/9207/commits/69bc8e79676a0bde3e1b28da8cdd832842ff18bc
laanwj merged this on Nov 23, 2016
laanwj closed this on Nov 23, 2016
laanwj referenced this in commit fa1f944107 on Nov 23, 2016
codablock referenced this in commit 796bed1247 on Jan 15, 2018
andvgal referenced this in commit 7b8c2d0d05 on Jan 6, 2019
CryptoCentric referenced this in commit b77d4f7fc1 on Feb 24, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels