Trivial refactor: Remove extern keyword from function declarations #9244

pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:no-extern-funcdecl changing 1 files +11 −11

kallewoof commented at 4:41 AM on November 30, 2016: member

Reason: they are extern by default.

Same-binary check passes:

$ ../bitcoin-maintainer-tools/build-for-compare.py e56cf67e6b3f2e87bee42aaa5ab709f479c9e6ca 446a8f9c90400518bbd4f52f82520c9a97b3a7b3
[...]
>>> [do_build] Copying object files...
>>> [do_build] Performing basic analysis pass...
>>> [do_build] Use these commands to compare results:
>>> [do_build] $ sha256sum /tmp/compare/*.stripped
>>> [do_build] $ git diff -W --word-diff /tmp/compare/e56cf67e6b3f2e87bee42aaa5ab709f479c9e6ca /tmp/compare/446a8f9c90400518bbd4f52f82520c9a97b3a7b3
$ sha256sum /tmp/compare/*.stripped
a5d4480faae4cdfb482ea70d91a19450b7da3f3134a9e477bfc1cab86c29ca8f  /tmp/compare/bitcoind.446a8f9c90400518bbd4f52f82520c9a97b3a7b3.stripped
a5d4480faae4cdfb482ea70d91a19450b7da3f3134a9e477bfc1cab86c29ca8f  /tmp/compare/bitcoind.e56cf67e6b3f2e87bee42aaa5ab709f479c9e6ca.stripped
$ git diff -W --word-diff /tmp/compare/e56cf67e6b3f2e87bee42aaa5ab709f479c9e6ca /tmp/compare/446a8f9c90400518bbd4f52f82520c9a97b3a7b3
$

Trivial refactor: Remove extern keyword from function declarations, as they are extern by default. 446a8f9c90
fanquake added the label Refactoring on Nov 30, 2016
jonasschnelli commented at 7:43 AM on November 30, 2016: contributor

utACK 69337dcab02e2e972711781ae1fba7f541d67b17
gmaxwell commented at 3:13 PM on November 30, 2016: contributor

utACK
sipa commented at 7:54 PM on November 30, 2016: member

utACK
paveljanik commented at 8:21 PM on November 30, 2016: contributor

ACK 446a8f9
MarcoFalke commented at 9:03 PM on November 30, 2016: member

ACK 446a8f9
sipa merged this on Dec 1, 2016
sipa closed this on Dec 1, 2016
sipa referenced this in commit 72ae6f8cf0 on Dec 1, 2016
kallewoof deleted the branch on Dec 1, 2016
codablock referenced this in commit 7a9b349164 on Jan 16, 2018
codablock referenced this in commit daf2e01b26 on Jan 16, 2018
codablock referenced this in commit a78e0e36c6 on Jan 17, 2018
andvgal referenced this in commit 596236c29e on Jan 6, 2019
CryptoCentric referenced this in commit f4522c0918 on Feb 25, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels