Improvement of documentation of command line parameter 'whitelist' #9249

pull ghost wants to merge 1 commits into bitcoin:master from changing 1 files +5 −5

ghost commented at 3:27 PM on November 30, 2016: none

I wonder what "netmask" one should give here. E.g. for 24 bit netmask give whitelist=24 ? What use should that have? If I guess correctly, what is meant here is a network segment, not a netmask. So, e.g. I expect one can say whitelist=1.2.3.0/24

Improvement of documentation of command line parameter 'whitelist'

I wonder what "netmask" one should give here. E.g. for 24 bit netmask give `whitelist=24` ? What use should that have?
If I guess correctly, what is meant here is a network segment, not a netmask. So, e.g. I expect one can say `whitelist=1.2.3.0/24`

8a639e11bb

gmaxwell commented at 3:30 PM on November 30, 2016: contributor

ACK.
paveljanik commented at 3:35 PM on November 30, 2016: contributor

Nica catch, utACK 8a639e1
MarcoFalke commented at 3:46 PM on November 30, 2016: member

Please just fix it upstream. https://github.com/bitcoin/bitcoin/blob/40022fe5f2b576d023fa260eb176bde6d0779330/src/init.cpp#L394

We will take care to populate it downstream.

On Wed, Nov 30, 2016 at 4:35 PM, paveljanik notifications@github.com wrote:

Nica catch, utACK 8a639e1 https://github.com/bitcoin/bitcoin/commit/8a639e11bbc01384b7ee4bbbabe6334cb16e8556

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/9249#issuecomment-263904352, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv7Sf5tcmoqAlLaUCt1HJASUNcChnks5rDZe-gaJpZM4LAUYf .
ghost commented at 4:28 PM on November 30, 2016: none

Sorry, I have made a mess. I don't know github so good. No I do not know anymore what to do.... :-/

https://github.com/wodry/bitcoin/commit/db04974eba6eb27816c0da5a3b1c5ecbedcf5978 was wrong because there was "given given" double word.
MarcoFalke commented at 4:37 PM on November 30, 2016: member

No worries, you can add commits as you like to fix mistakes, we can take care of squashing later. (Also, please close one of the two pulls)

On Wed, Nov 30, 2016 at 5:28 PM, wodry notifications@github.com wrote:

Sorry, I have made a mess. I don't know github so good. No I do not know anymore what to do.... :-/

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/9249#issuecomment-263920477, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv9-ylVxQVEz3gOQDBcIGozoXXZHAks5rDaQxgaJpZM4LAUYf .
ghost commented at 5:34 PM on November 30, 2016: none

Closed in favour of https://github.com/bitcoin/bitcoin/pull/9251
unknown closed this on Nov 30, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Linked (view graph)

#9251 Improvement of documentation of command line parameter 'whitelist'