0.13.2 backports

laanwj commented at 7:12 am on December 2, 2016: member

This backports all the current merged “backport needed” pulls with milestone “0.13.2”.

Conflicts:

#9199 src/main.cpp, function MaybeSetPeerAsAnnouncingHeaderAndIDs: code was formulated differently
- conflicts with #8085 53347f0cb99e514815e44a56439a4a10012238f8 net: create generic functor accessors and move vNodes to CConnman
#9189 src/main.cpp, function GenerateCoinbaseCommitment: trivial change/remove conflict
- conflicts with #9125 1662b437b33b7ec5a1723f6ae6187d3bdd06f593 Make CBlock::vtx a vector of shared_ptr<CTransaction>
#9188 src/main.cpp, function ProcessMessage: trivial variable naming
- conflicts with #8655 4731cab8fbff51a8178c85d572e2482040278616 Do not shadow variables @gmaxwell @sipa can you take a look at the backports of the above pulls and see if the conflicts were resolved in the right way.

laanwj added the label Backport on Dec 2, 2016

fanquake added this to the milestone 0.13.2 on Dec 2, 2016

build: fix qt5.7 build under macOS

OBJCXX's std flags don't get defined by our cxx macro. Rather than hard-coding
to c++11, just force OBJCXX to be the same as CXX unless the user specified
otherwise.

Github-Pull: #9169
Rebased-From: 70266e98292bf9c8f019ca4b11d681b575f71448

d1b4da9259

log block size and weight correctly.

Github-Pull: #8838
Rebased-From: 5f274a1749acfdf331bc2931e25ac80c346e5faa

094848baf0

Always drop the least preferred HB peer when adding a new one.

When a BIP152 HB-mode peer is in the least preferred position and
 disconnects, they will not be by ForNode on the next loop. They
 will continue to sit in that position and prevent deactivating
 HB mode for peers that are still connected.

There is no reason for them to stay in the list if already gone,
 so drop the first element unconditionally if there are too many.

Fixes issue #9163.

Github-Pull: #9199
Rebased-From: ca8549d2bd32f17f8b69d1edbe3f2976fba504b4

da5a16b11d

Always add default_witness_commitment with GBT client support

Github-Pull: #9189
Rebased-From: ad04d1cb35b9612d36078c62213bdbb13f56d73d

99477c71c4

[qa] Test getblocktemplate default_witness_commitment

Github-Pull: #9189
Rebased-From: 95f4a03777ec2ad82a94a3e2890192a93ad83509

b96a8f7df2

Make orphan parent fetching ask for witnesses.

In 0.13 orphan transactions began being treated as implicit
 INVs for their parents.  But the resulting getdata were
 not getting the witness flag.

This fixes issue #9182 reported by chjj and roasbeef on IRC.

Github-Pull: #9188
Rebased-From: 5b0150a060208faf436c09b0ca9463407a869c72

ca1fd7521e

laanwj force-pushed on Dec 2, 2016

Use RelevantServices instead of node_network in AttemptToEvict.

Use of node_network here is really meant to be a proxy of "likely to
 send us blocks in the future".  RelevantServices is the right criteria
 now.

Github-Pull: #9052
Rebased-From: d32036a47d9ccdc38628a7a75bb8b711af462e4f

3a3bcbf775

Update INSTALL landing redirection notice for build instructions.

Github-Pull: #8896
Rebased-From: 2920be2a6994cfbffd93e72c6cf4c1ed19ac4339

975ab1254e

Simple Update to File 'bitcoin-qt.desktop'

Github-Pull: #8908
Rebased-From: 164196b7c8aecb72dd20c8681bb24b81b18aecaa

4a974b2837

[build-aux] Boost_Base serial 27

Github-Pull: #8920
Rebased-From: 282abd8358e254d976cad05d0eb48586db276bcd

c134d9206d

Set minimum required Boost to 1.47.0

Github-Pull: #8920
Rebased-From: 6dd37237222f7102e223ece948150cb5c5087e3c

40169dcda9

add software-properties-common

This allows using `add-apt-repository`.

Github-Pull: #8929
Rebased-From: aa9d3c9a503952589b359624bbb0da11dd7a5e3f

12428b4d8a

Sync bitcoin-tx with tx version policy

Github-Pull: #8932
Rebased-From: b0aea8057921f0ed2288cf07048f652c7d6d9cf3

106da691a5

[Qt] make warnings label selectable

Github-Pull: #8972
Rebased-From: ef0c9ee2960fda58b2fe5b0c3b4c672231b30322

6f86b53643

Fix doxygen comment: the transaction is returned in txOut

Github-Pull: #8993
Rebased-From: 1d8e12ba48154b2c59213e92efb50958d430a007

973ca1e491

[rpc] ParseHash: Fail when length is not 64

Github-Pull: #9042
Rebased-From: fa326193ad739d1f93da456b3fa73af0bbf9fdd1

5bcb05d4e1

Fix exit codes:

- `--help`, `--version` etc should exit with `0` i.e. no error ("not enough args" case should still trigger an error)
- error reading config file should exit with `1`

Slightly refactor AppInitRPC/AppInitRawTx to return standard exit codes (EXIT_FAILURE/EXIT_SUCCESS) or CONTINUE_EXECUTION (-1)

Github-Pull: #9067
Rebased-From: bd0de1386e1c7f9b875d52290de0d561c8d56bc9

f85ee01303

Every main()/exit() should return/use one of EXIT_ codes instead of magic numbers

Github-Pull: #9067
Rebased-From: 4441018d0860fce64ee74fa78da79bbb21114ca9

f27596a7ec

Missed one "return false" in recent refactoring in #9067

Github-Pull: #9120
Rebased-From: 45d372f88900bda74835a20a44246746c2ac94e6

08d1c90113

qt: Use correct conversion function for boost::path datadir

Fixes #9089.

Github-Pull: #9094
Rebased-From: e760b307f6210bee293796d606bcca87f86be200

5f3a12c97c

net: don't send feefilter messages before the version handshake is complete

Github-Pull: #9117
Rebased-From: 46625538d674a5aaf1bcfa7c8be8a49e5a23fa9e

6fe3981ac8

fix getnettotals RPC description about timemillis.

Github-Pull: #9122
Rebased-From: a79f864945d7abe05e777a942864c181311e5070

f82c81b177

Doxygen: Set PROJECT_NAME = "Bitcoin Core"

Github-Pull: #9178
Rebased-From: fa63ee8e3eeef8379360c125eeb690a37f097da2

3fffbf7ef0

[Qt] fix coincontrol sort issue

Github-Pull: #9185
Rebased-From: 76af4eb876814a916dd4f26cf71faa20bdc54f2d

6d70a73968

[Qt] Clean up and fix coincontrol tree widget handling

- Do sorting for date, amount and confirmations column as longlong, not
  unsigned longlong.
- Use `UserRole` to store our own data. This makes it treated as
  ancillary data prevents it from being displayed.
- Get rid of `getMappedColumn` `strPad` - these are no longer necessary.
- Get rid of hidden `_INT64` columns.
- Start enumeration from 0 (otherwise values are undefined).

Github-Pull: #9185
Rebased-From: 4231032bfcb9728f0f629b3d67884ba9de63e4ff

ff423cc6b0

qt: Plug many memory leaks

None of these are very serious, and are leaks in objects that are
created at most one time.

In most cases this means properly using the QObject parent hierarchy,
except for BanTablePriv/PeerTablePriv which are not QObject,
so use a std::unique_ptr instead.

Github-Pull: #9190
Rebased-From: 47db07537746940ee7dd0739a8c73e328837813f

dc46b10a08

qt: Prevent thread/memory leak on exiting RPCConsole

Make ownership of the QThread object clear, so that the RPCConsole
can wait for the executor thread to quit before shutdown is called. This
increases overall thread safety, and prevents some objects from leaking
on exit.

Github-Pull: #9190
Rebased-From: 693384eedb1ac7f449e226edd53e2cb52a86e279

c12f4e93b9

qt: Avoid splash-screen related memory leak

Make splash screen queue its own deletion when it receives the finished
command, instead of relying on WA_DeleteOnClose which doesn't work under
these circumstances.

Github-Pull: #9190
Rebased-From: e4f126a7ba66e7317718c30276dff6db92dc1986

e4bea4fb84

qt: Avoid shutdownwindow-related memory leak

Store a reference to the shutdown window on BitcoinApplication,
so that it will be deleted when exiting the main loop.

Github-Pull: #9190
Rebased-From: 5204598f8d07d7432d91e9b8781806d2f3d16415

e5ad693f91

qt: Avoid OpenSSL certstore-related memory leak

- Correctly manage the X509 and X509_STORE objects lifetime.

Github-Pull: #9190
Rebased-From: ed998ea7a0ecf294211b06e9ef82f1548a621a1d

6f7841c4d4

Send tip change notification from invalidateblock

This change is needed to prevent sync_blocks timeouts in the mempool_reorg
test after the sync_blocks update in the upcoming commit
"[qa] Change sync_blocks to pick smarter maxheight".

This change was initially suggested by Suhas Daftuar <sdaftuar@chaincode.com>
in https://github.com/bitcoin/bitcoin/pull/8680#r78209060

Github-Pull: #9196
Rebased-From: 67c6326abd1788e6f411feb4f44b69774e76aae2

0c09d9f00e

bench: Fix subtle counting issue when rescaling iteration count

Make sure that the count is a zero modulo the new mask before
scaling, otherwise the next time until a measure triggers
will take only 1/2 as long as accounted for. This caused
the 'min time' to be potentially off by as much as 100%.

Github-Pull: #9200
Rebased-From: e0a9cb25b0af87723d50cb8d8cffa10f1ebf7dcc

eebc699d30

Include select.h when WIN32 is not defined

Github-Pull: #9224
Rebased-From: 498a1d75e75649b02caeca7b1bc9bbc19e51a566

396c405e7b

Fix calculation of number of bound sockets to use

Github-Pull: #9253
Rebased-From: 9e1f46821d5bb69e2cbf25738eefa7c6cb99c838

28d0f224fd

Update gitian signing key of jl2012

Github-Pull: #8950
Rebased-From: 9b0d8efe811058928a6ed3a55c0b6d58e13b22ba

ff55a2d22e

instance of 'mem pool' to 'mempool'

there was only one instance of  'mem pool' and not 'mempool', so I changed it to conform to the others

Github-Pull: #9029
Rebased-From: 1c3ecc70c8cd6c33cf3ff4e2099c8e7d8a8ca9d2

b1e978cfd6

Change all instance of 'GMT epoch' to 'Unix epoch'

Github-Pull: #9041
Rebased-From: 7f61b49de82989dc692e7750860eb1ec4044db7a

87fbcede5c

Add script tests for FindAndDelete in pre-segwit and segwit scripts

Github-Pull: #8927
Rebased-From: acf853df910339412bafb1743f42af1774f5b910

387ec9d963

[qa] test_framework: Exit when tmpdir exists

Github-Pull: #9098
Rebased-From: fae19aa1da0858678874815b344de83e1ee3a1bd

ecd7db5767

[qa] rpc-tests: Apply random offset to portseed

This helps to skip over resources, which are blocked by regtest bitcoind
zombie nodes

Github-Pull: #9098
Rebased-From: fab0f07dec8d6e21ab70843fdce101f1703588fd

58eab244fb

laanwj commented at 8:19 am on December 2, 2016: member

Pulled some further backports that weren’t tagged but suggested and backported by @luke-jr.

MarcoFalke commented at 7:36 pm on December 2, 2016: member

Maybe #9251 as well?

Improvement of documentation of command line parameter 'whitelist'

Github-Pull: #9251
Rebased-From: 8a70a9da3da0df5c376042b18b87f0a63e88d2e3

a710a43040

laanwj commented at 11:13 am on December 3, 2016: member

Maybe #9251 as well?

Added.

Add option to return non-segwit serialization via rpc

Github-Pull: #9194
Rebased-From: 835c75acaac004c3315395dcd7d1f193dfb9e5da

21ccb9f253

Adapt ZMQ/rest serialization to take rpcserialversion arg

Github-Pull: #9194
Rebased-From: ad5c4c93cae53a2a6f74880ca11b4d788677a378

f26dab7e90

gmaxwell commented at 4:26 am on December 6, 2016: contributor

I’ve reviewed all the backports of my commits here, so ACK on that.

laanwj commented at 7:45 am on December 6, 2016: member

Added #9194. @instagibbs I did the backporting yesterday, so if you changed anything important in the rebase I won’t have it picked up here. Please check.

instagibbs commented at 1:34 pm on December 6, 2016: member

@laanwj quick check ACK. Only differences I know about are CTransactionRef and dropped no extern in front of EncodeHexTX.

gmaxwell commented at 5:33 am on December 14, 2016: contributor

Tested ACK.

laanwj merged this on Dec 14, 2016

laanwj closed this on Dec 14, 2016

laanwj referenced this in commit 423659c951 on Dec 14, 2016

rebroad commented at 2:20 am on January 4, 2017: contributor

Any reason #9088 is missing?

MarcoFalke commented at 2:57 am on January 4, 2017: member

@rebroad The modal overlay is not in 0.13.2?

MarcoFalke locked this on Sep 8, 2021

0.13.2 backports #9264