[0.13] Disable fee estimates for a confirm target of 1 block #9267

1. 
   morcos commented at 3:44 pm on December 2, 2016: member

   For 0.13.2

   Backport of #9239 without GUI changes and fixing conflicts in tests.

   Tested and it works just as if the estimation algo would have returned -1 in which case you can still set the slider to the 1 block confirmation target but it gives you an answer for 2 (and tells you so). @laanwj some slight conflicts in the test, so i fixed them up here.

2. Disable fee estimates for a confirm target of 1 block

   Backport of #9239 without GUI changes and fixing conflicts in tests.

   3688866880
3. MarcoFalke added the label Backport on Dec 2, 2016
4. MarcoFalke added this to the milestone 0.13.2 on Dec 2, 2016
5. in src/rpc/mining.cpp: in 3688866880

   790@@ -791,6 +791,8 @@ UniValue estimatefee(const UniValue& params, bool fHelp)
   791             "\n"
   792             "A negative value is returned if not enough transactions and blocks\n"
   793             "have been observed to make an estimate.\n"
   794+            "-1 is always returned for nblocks == 1 as it is impossible to calculate\n"
   

   ---

   ---

   

   dcousens commented at 0:10 am on December 3, 2016:

   -1 is always returned for nblocks == 1

   if (confTarget == 1) confTarget = 2;

   Which is it? Or am I was misunderstanding the changes ?

   edit: nevermind

6. 
   gmaxwell commented at 1:08 am on December 3, 2016: contributor

   utACK.
7. 
   laanwj commented at 10:57 am on December 3, 2016: member

   Thanks. utACK 3688866
8. laanwj merged this on Dec 3, 2016
9. laanwj closed this on Dec 3, 2016

   ---

10. laanwj referenced this in commit 0a4aa87623 on Dec 3, 2016
11. 
    shyii commented at 7:41 pm on December 3, 2016: none

    Sharday
12. MarcoFalke renamed this:
    Disable fee estimates for a confirm target of 1 block
    [0.13] Disable fee estimates for a confirm target of 1 block
    on Dec 14, 2016
13. DrahtBot locked this on Sep 8, 2021

Contributors
morcos dcousens gmaxwell laanwj shyii

Labels
Backport

Milestone
0.13.2