Make send coins dialog honor the configured unit type even on the first attempt. #928

pull jojkaart wants to merge 1 commits into bitcoin:master from jojkaart:master changing 1 files +1 −0
  1. jojkaart commented at 11:29 pm on March 10, 2012: none
    This fixes the issue of send coins dialog initially having BTC selected as the unit to be sent even when, for example, mBTC is chosen as the default unit.
  2. laanwj commented at 5:14 pm on March 12, 2012: member

    Ha, good fix.

    Is there any specific reason to do it only on first setModel?

  3. jojkaart commented at 8:30 am on March 13, 2012: none

    setModel appears to be the function used to give the dialog the user settings (as well as some other things). At present setModel only sets the model, nothing else. So, since this is a bug fix, I wanted to limit the scope of the change to avoid unexpected consequences.

    I’m not actually familiar enough with the code to know if setModel is ever called more than once though. So it’s possible it’s an useless precaution.

  4. laanwj commented at 11:46 am on March 13, 2012: member

    Thanks for the explanation. I think it is safe to remove the precaution.

    Background: A model change in QT implies that the widget state is reset according to the information in the new model.

  5. jojkaart commented at 12:24 pm on March 16, 2012: none
    Based on your input, I’ve changed the fix to just simply just call the clear() function after setting the model.
  6. TheBlueMatt commented at 8:48 pm on March 18, 2012: member
    Can you rebase this into one commit?
  7. Make the sendcoins dialog use the configured unit type, even on the first attempt. aa3d4c0221
  8. laanwj referenced this in commit bd9c6f88be on Mar 19, 2012
  9. laanwj merged this on Mar 19, 2012
  10. laanwj closed this on Mar 19, 2012

  11. coblee referenced this in commit 7be4995c90 on Jul 17, 2012
  12. suprnurd referenced this in commit 5a8c0c9b9d on Dec 5, 2017
  13. ptschip referenced this in commit 33032d5da4 on Jan 20, 2018
  14. lateminer referenced this in commit 2482572f89 on Oct 30, 2019
  15. sipa referenced this in commit c020cbaa5c on Jul 14, 2021
  16. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me