While testing using BIP152 using the orphan map I observed a round trip that occurred only because the relevant orphan was time based expired first.
The purpose of the time based expiration is simply because the random eviction has particularly bad effects on chains of txn (it tends to poke holes in the chains, resulting in the pool filling with things that are unconnectable). As such, We don't really need the time based until just before the random eviction would take place.
While testing using BIP152 using the orphan map I observed a
round trip that occurred only because the relevant orphan was
time based expired first.
The purpose of the time based expiration is simply because the
random eviction has particularly bad effects on chains of txn
(it tends to poke holes in the chains, resulting in the pool
filling with things that are unconnectable). As such, We don't
really need the time based until just before the random eviction
would take place.
Concept ACK.
Also, we can avoid poking holes. We have a forward-pointing map (mapOrphansTransactionByPrev) - if random eviction selects an orphan which has descendants, we could randomly walk forward until we hit a leaf.
Closing because we should just make this smarter and since it wouldn't get backported, no need to rush.