[Qt] Console: add security warning #9330

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2016/12/qt_add_sec changing 1 files +6 −1

jonasschnelli commented at 3:01 PM on December 12, 2016: contributor

Adds a general warning to the Qt (Debug) Console regardless if the wallet is encrypted or not. The scope of this PR is also not to warn or disable certain private-key revealing commands (can be done in a separate PR).

Inspired by @laanwj's comment in... #8544 (comment)

<img width="852" alt="bildschirmfoto 2016-12-12 um 16 00 55" src="https://cloud.githubusercontent.com/assets/178464/21103802/36e36d00-c084-11e6-8d83-0407e9be8de1.png">
[Qt] Console: add security warning ed6b377ae2
jonasschnelli added the label GUI on Dec 12, 2016
luke-jr commented at 10:25 PM on December 12, 2016: member

utACK
paveljanik commented at 8:31 AM on December 13, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/9330/commits/ed6b377ae23d4ea812a18b43633a3a8692f0fc0a
MarcoFalke commented at 9:49 AM on December 13, 2016: member

utACK ed6b377ae23d4ea812a18b43633a3a8692f0fc0a
laanwj commented at 1:43 PM on December 13, 2016: member

Utack. Thanks!

On Dec 13, 2016 10:49 AM, "MarcoFalke" notifications@github.com wrote:

utACK ed6b377 https://github.com/bitcoin/bitcoin/commit/ed6b377ae23d4ea812a18b43633a3a8692f0fc0a

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/9330#issuecomment-266693886, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHutqFx2fM9Tx4Oh7hRL3huzbYsS-lUks5rHmougaJpZM4LKo7v .
laanwj merged this on Dec 14, 2016
laanwj closed this on Dec 14, 2016
laanwj referenced this in commit 47e6a19e6b on Dec 14, 2016
codablock referenced this in commit 93cb8e6729 on Jan 16, 2018
codablock referenced this in commit 4d552524bb on Jan 16, 2018
codablock referenced this in commit 5c860b3477 on Jan 17, 2018
andvgal referenced this in commit cefea5ac84 on Jan 6, 2019
CryptoCentric referenced this in commit 7f157957a5 on Feb 25, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8544 wallet: RPC calls that "leak" private keys should be disabled by default