Let wallet importmulti RPC accept labels for standard scriptPubKeys #9332

1. 
   ryanofsky commented at 3:52 pm on December 12, 2016: member

   Allow importmulti RPC to apply address labels when importing standard scriptPubKeys. This makes the importmulti RPC less finnicky about import formats and also simpler internally.
2. ryanofsky force-pushed on Dec 12, 2016
3. fanquake added the label RPC/REST/ZMQ on Dec 13, 2016
4. ryanofsky force-pushed on Dec 13, 2016
5. ryanofsky force-pushed on Dec 15, 2016
6. ryanofsky force-pushed on Dec 15, 2016
7. ryanofsky renamed this:
   Let wallet importmulti RPC accept labels for standard scriptPubKeys (on top of #9331)
   Let wallet importmulti RPC accept labels for standard scriptPubKeys
   on Dec 15, 2016
8. ryanofsky force-pushed on Mar 1, 2017
9. ryanofsky force-pushed on Mar 3, 2017
10. ryanofsky force-pushed on Jun 2, 2017
11. ryanofsky force-pushed on Sep 20, 2017
12. ryanofsky force-pushed on Oct 19, 2017
13. ryanofsky force-pushed on Jan 25, 2018
14. Let wallet importmulti RPC accept labels for standard scriptPubKeys

    Allow importmulti RPC to apply address labels when importing standard
    scriptPubKeys. This makes the importmulti RPC less finnicky about import
    formats and also simpler internally.

    98ea64cf23
15. ryanofsky force-pushed on Feb 23, 2018
16. in test/functional/wallet_import_rescan.py:169 in 98ea64cf23

    165@@ -166,7 +166,7 @@ def run_test(self):
    166 
    167         # Create new transactions sending to each address.
    168         for i, variant in enumerate(IMPORT_VARIANTS):
    169-            variant.sent_amount = 10 - (2 * i + 1) / 8.0
    170+            variant.sent_amount = 1 - (2 * i + 1) / 128
    

    ---

    ---

    

    jamesob commented at 9:21 pm on March 7, 2018:

    Curious what’s prompting these value changes.

    ---

    

    ryanofsky commented at 2:37 pm on March 8, 2018:

    Curious what’s prompting these value changes.

    This is just reducing the amount sent each iteration to prevent the wallet running out of funds because there are more test variants now.

17. 
    jamesob commented at 9:29 pm on March 7, 2018: member

    utACK https://github.com/bitcoin/bitcoin/pull/9332/commits/98ea64cf232c34d4b1aebe738b3956191667cd76

    I don’t see anything in the tests exercising the application of a label to a scriptPubKey import; if we’re indeed lacking that I’m happy to either add a commit here or file a follow-up PR.

18. 
    ryanofsky commented at 2:55 pm on March 8, 2018: member

    I don’t see anything in the tests exercising the application of a label to a scriptPubKey import; if we’re indeed lacking that I’m happy to either add a commit here or file a follow-up PR.

    This is tested in wallet_import_rescan.py on line 61 when the call type is Call.multiscript. (If you revert the code changes and run the test you should see this case fail.)

19. 
    DrahtBot commented at 5:30 pm on July 21, 2018: member
20. DrahtBot closed this on Jul 21, 2018

    ---

21. DrahtBot reopened this on Jul 21, 2018

    ---

22. 
    sipa commented at 9:16 pm on July 21, 2018: member

    utACK 98ea64cf232c34d4b1aebe738b3956191667cd76. Looks like a nice simplification too.
23. 
    laanwj commented at 5:02 pm on September 10, 2018: member

    utACK 98ea64cf232c34d4b1aebe738b3956191667cd76
24. laanwj merged this on Sep 10, 2018
25. laanwj closed this on Sep 10, 2018

    ---

26. laanwj referenced this in commit 13c842e028 on Sep 10, 2018
27. deadalnix referenced this in commit a6b244747e on May 14, 2020
28. ftrader referenced this in commit 223ac15a24 on Aug 17, 2020
29. PastaPastaPasta referenced this in commit a9129d0f30 on Jun 27, 2021
30. PastaPastaPasta referenced this in commit 0a64be4868 on Jun 28, 2021
31. PastaPastaPasta referenced this in commit 8ea4c51188 on Jun 29, 2021
32. PastaPastaPasta referenced this in commit aade9c3100 on Jul 1, 2021
33. DrahtBot locked this on Sep 8, 2021

Contributors
ryanofsky jamesob DrahtBot sipa laanwj

Labels
RPC/REST/ZMQ