Change SIG_NULLFAIL => NULLFAIL. #9342

pull richardkiss wants to merge 1 commits into bitcoin:master from richardkiss:feature/unify_nullfail changing 4 files +5 −5

richardkiss commented at 4:02 PM on December 13, 2016: contributor

In src/test/script_tests.cpp the ScriptErrorDesc entries all take the form {SCRIPT_ERR_XXX, "XXX"} except for { SCRIPT_ERR_SIG_NULLFAIL, "NULLFAIL" }. This patch corrects this oversight.
Change SIG_NULLFAIL => NULLFAIL. 691ace3339
paveljanik commented at 9:50 PM on December 13, 2016: contributor

NACK

What about "NULLFAIL" -> "SIG_NULLFAIL" to unify SCRIPT_ERR_SIG*?
richardkiss commented at 10:09 PM on December 13, 2016: contributor

I can submit a patch that goes the other way (NULLFAIL => SIG_NULLFAIL) if the consensus is that way is preferable. I'm agnostic.
richardkiss commented at 10:58 PM on December 13, 2016: contributor

See https://github.com/bitcoin/bitcoin/compare/master...richardkiss:feature/unify_sig_nullfail?expand=1 for a look at the other direction. This requires quite a few more changes.
fanquake added the label Validation on Dec 14, 2016
kallewoof commented at 4:53 AM on February 9, 2017: member

SIG_NULLFAIL refers to the signature (not) being null, so shortening to NULLFAIL is NACK from me. Concept ACK on NULLFAIL -> SIG_NULLFAIL. There's also SCRIPT_VERIFY_NULLFAIL which I think should probably ideally be SCRIPT_VERIFY_SIG_NULLFAIL.
richardkiss commented at 10:46 PM on February 13, 2017: contributor

Submitted alternative pull request https://github.com/bitcoin/bitcoin/pull/9754
fanquake commented at 11:10 PM on March 22, 2017: member

Going to close this due to a few NACKs and not much other feedback. Will leave #9754 open.
fanquake closed this on Mar 22, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#9754 Change NULLFAIL => SIG_NULLFAIL.