Prior to this commit, the fFromMe member was written to and serialized but not actually used in any meaningful way.
The one place where the fFromMe was used in a nontrivial way was CWallet::AddToWallet, but the only actual effect it had there was to trigger additional CWalletDB::WriteTx calls that would change serialized fFromMe fields in previously existing database rows from false to true (without changing other fields).
CreateTransaction().
Although not sure how useful this would be.
Prior to this commit, the fFromMe member was written to and serialized but not
actually used in any meaningful way.
The one place where the fFromMe was used in a nontrivial way was
CWallet::AddToWallet, but the only actual effect it had there was to trigger
additional CWalletDB::WriteTx calls that would change serialized fFromMe fields
in previously existing database rows from false to true (without changing other
fields).
@jonasschnelli’s comment helped me understand the purpose of the fFromMe field, and now I kind of think it’s worth keeping, especially since getting rid of it doesn’t simplify things much.
I changed my commit for now to just document the fFromMe field instead of getting rid of it.
@ryanofsky This was made dead by changes to the trickle logic
originally the use was for this one line
if (wtx.fFromMe) fTrickleWait = true;
I dont see any reason not to remove it.
Ok @pstratem, removed fFromMe again. I don’t have any opinion on whether it should be kept or removed. I just think it should be documented as in commit https://github.com/bitcoin/bitcoin/pull/9351/commits/39c77b00e3d61dfea1f45be5d3b77e5adea7b91a if it is not removed.
Reasons I could imagine why someone might not want to remove it is that it provides a nice little clue about the origin of a transaction that could be useful for debugging, or to show as information in the UI. Also, removing the variable doesn’t simplify the code very much. Another reason to keep it might be that having it could make it easier to remove the fTimeReceivedIsTxTime variable which I think is actually a stranger thing to serialize. It has similar meaning to fFromMe, but unlike fFromMe is not merged properly in AddToWallet.