Remove unused test files and references

btcdrak commented at 7:45 am on December 19, 2016: contributor

Refs #7562

Remove unused test files and references 23208ac81b

fanquake added the label Tests on Dec 19, 2016

laanwj commented at 9:00 am on December 19, 2016: member

This must have broken make distdir. Unsure how did it pass the Travis tests.

utACK https://github.com/bitcoin/bitcoin/pull/9376/commits/23208ac81b718508a4f5d0fbb20029941c96049d: verified that test/data/blanktx.hex is indeed gone and should not be referenced, and that test/data/txcreatesign.json is unreferenced and can go.

fanquake commented at 10:36 am on December 20, 2016: member

@laanwj Yes it looks like make distdir has been broken.

0$ make distdir
1if test -d "bitcoin-0.13.99"; then find "bitcoin-0.13.99" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "bitcoin-0.13.99" || { sleep 5 && rm -rf "bitcoin-0.13.99"; }; else :; fi
2test -d "bitcoin-0.13.99" || mkdir "bitcoin-0.13.99"
3 (cd src && /Applications/Xcode.app/Contents/Developer/usr/bin/make  top_distdir=../bitcoin-0.13.99 distdir=../bitcoin-0.13.99/src \
4     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
5Generated bench/data/block413567.raw.h
6Generated test/data/tx_valid.json.h
7make[1]: *** No rule to make target `test/data/blanktx.hex', needed by `distdir'.  Stop.
8make: *** [distdir] Error 1

However after merging this I still see:

0config.status: executing depfiles commands
1make[1]: *** No rule to make target `test/data/txcreatesign.hex', needed by `distdir'.  Stop.
2make: *** [distdir] Error 1

@btcdrak Could you fixup that reference? Looks like it’s now txcreatesignv1.hex?

laanwj commented at 12:47 pm on December 20, 2016: member

@theuni Shouldn’t Travis pick up problems like this? It always did for me, although now that I think of it that was when forgetting to specify .h files.

MarcoFalke commented at 1:06 pm on December 20, 2016: member

@laanwj Travis never does the distdir step, I think.

On Tue, Dec 20, 2016 at 1:47 PM, Wladimir J. van der Laan < notifications@github.com> wrote:

@theuni https://github.com/theuni Shouldn’t Travis pick up problems like this? It always did for me, although now that I think of it that was when forgetting to specify .h files.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/9376#issuecomment-268235041, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv62Fyb17XHp0q4b6toRWo4VrPGxSks5rJ855gaJpZM4LQc6h .

laanwj commented at 2:22 pm on December 20, 2016: member

Okay, then I must be confused with gitian. I thought it did that before building. But maybe that’s only gitian.

ghost commented at 4:10 pm on December 20, 2016: none

I got this error

 0+ make dist
 1make  dist-gzip am__post_remove_distdir='@:'
 2make[1]: Entering directory `/home/ubuntu/build/bitcoin'
 3if test -d "bitcoin-0.13.99"; then find "bitcoin-0.13.99" -type d ! -perm -200 -                     exec chmod u+w {} ';' && rm -rf "bitcoin-0.13.99" || { sleep 5 && rm -rf "bitcoi                     n-0.13.99"; }; else :; fi
 4test -d "bitcoin-0.13.99" || mkdir "bitcoin-0.13.99"
 5 (cd src && make  top_distdir=../bitcoin-0.13.99 distdir=../bitcoin-0.13.99/src                      \
 6     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
 7make[2]: Entering directory `/home/ubuntu/build/bitcoin/src'
 8Generated bench/data/block413567.raw.h
 9Generated test/data/script_tests.json.h
10Generated test/data/base58_keys_valid.json.h
11Generated test/data/base58_encode_decode.json.h
12Generated test/data/base58_keys_invalid.json.h
13Generated test/data/tx_invalid.json.h
14Generated test/data/tx_valid.json.h
15Generated test/data/sighash.json.h
16make[2]: *** No rule to make target `test/data/blanktx.hex', needed by `distdir'                     .  Stop.
17make[2]: Leaving directory `/home/ubuntu/build/bitcoin/src'
18make[1]: *** [distdir] Error 1
19make[1]: Leaving directory `/home/ubuntu/build/bitcoin'
20make: *** [dist] Error 2

theuni commented at 6:07 pm on December 20, 2016: member

@laanwj IIRC we used to have a distcheck in Travis, but got rid of it a while ago because it was too heavy. Or maybe it was that it used distdir before the out-of-tree build?

I think we could probably add back the lighter make distdir at the end to catch these things.

Fix testfile reference 9cb66248dc

btcdrak commented at 7:50 pm on December 20, 2016: contributor

Could you fixup that reference? Looks like it’s now txcreatesignv1.hex? @fanquake done.

fanquake commented at 11:37 pm on December 20, 2016: member

@btcdrak Thanks, looks better now:

 0bash-3.2$ make distdir
 1if test -d "bitcoin-0.13.99"; then find "bitcoin-0.13.99" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "bitcoin-0.13.99" || { sleep 5 && rm -rf "bitcoin-0.13.99"; }; else :; fi
 2test -d "bitcoin-0.13.99" || mkdir "bitcoin-0.13.99"
 3 (cd src && /Applications/Xcode.app/Contents/Developer/usr/bin/make  top_distdir=../bitcoin-0.13.99 distdir=../bitcoin-0.13.99/src \
 4     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
 5 (cd secp256k1 && /Applications/Xcode.app/Contents/Developer/usr/bin/make  top_distdir=../../bitcoin-0.13.99 distdir=../../bitcoin-0.13.99/src/secp256k1 \
 6     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
 7:
 8test -d "../../bitcoin-0.13.99/src/secp256k1" || mkdir "../../bitcoin-0.13.99/src/secp256k1"
 9test -n ":" \
10	|| find "../../bitcoin-0.13.99/src/secp256k1" -type d ! -perm -755 \
11		-exec chmod u+rwx,go+rx {} \; -o \
12	  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
13	  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
14	  ! -type d ! -perm -444 -exec /bin/sh /Users/michael/bitcoin/src/secp256k1/build-aux/install-sh -c -m a+r {} {} \; \
15	|| chmod -R a+r "../../bitcoin-0.13.99/src/secp256k1"
16 (cd univalue && /Applications/Xcode.app/Contents/Developer/usr/bin/make  top_distdir=../../bitcoin-0.13.99 distdir=../../bitcoin-0.13.99/src/univalue \
17     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
18:
19test -d "../../bitcoin-0.13.99/src/univalue" || mkdir "../../bitcoin-0.13.99/src/univalue"
20test -n ":" \
21	|| find "../../bitcoin-0.13.99/src/univalue" -type d ! -perm -755 \
22		-exec chmod u+rwx,go+rx {} \; -o \
23	  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
24	  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
25	  ! -type d ! -perm -444 -exec /bin/sh /Users/michael/bitcoin/src/univalue/build-aux/install-sh -c -m a+r {} {} \; \
26	|| chmod -R a+r "../../bitcoin-0.13.99/src/univalue"
27 (cd doc/man && /Applications/Xcode.app/Contents/Developer/usr/bin/make  top_distdir=../../bitcoin-0.13.99 distdir=../../bitcoin-0.13.99/doc/man \
28     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
29/Applications/Xcode.app/Contents/Developer/usr/bin/make  \
30	  top_distdir="bitcoin-0.13.99" distdir="bitcoin-0.13.99" \
31	  dist-hook
32/usr/local/bin/git archive --format=tar HEAD -- src/clientversion.cpp | ${TAR-tar} -C bitcoin-0.13.99 -xf -
33test -n "" \
34	|| find "bitcoin-0.13.99" -type d ! -perm -755 \
35		-exec chmod u+rwx,go+rx {} \; -o \
36	  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
37	  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
38	  ! -type d ! -perm -444 -exec /bin/sh /Users/michael/bitcoin/build-aux/install-sh -c -m a+r {} {} \; \
39	|| chmod -R a+r "bitcoin-0.13.99"

ACK https://github.com/bitcoin/bitcoin/pull/9376/commits/9cb66248dc7e1c782256d1f69ad67f9c63fb61f8

laanwj commented at 8:03 am on December 21, 2016: member

@laanwj IIRC we used to have a distcheck in Travis, but got rid of it a while ago because it was too heavy. Or maybe it was that it used distdir before the out-of-tree build?

The travis check was the only way most people were even noticing inconsistencies in the Makefile with regard to installed files, this is why pulls like this are popping up all over the place now.

It would be fine even if only one Travis builder built from distdir.

laanwj merged this on Dec 21, 2016

laanwj closed this on Dec 21, 2016

laanwj referenced this in commit 8dfe9fcb90 on Dec 21, 2016

droark commented at 6:51 pm on December 21, 2016: contributor

Posthumous ACK

blanktx.json is still sitting around unused. I believe it can be used for a v1 JSON test that doesn’t seem to exist right now. I’ll file a PR where I change it to blanktxv1.json and integrate it into the test suite.

btcdrak deleted the branch on Dec 21, 2016

codablock referenced this in commit b72f9249d9 on Jan 20, 2018

andvgal referenced this in commit fb97344113 on Jan 6, 2019

CryptoCentric referenced this in commit 4440487393 on Feb 27, 2019

CryptoCentric referenced this in commit de6eeec6e5 on Mar 5, 2019

MarcoFalke locked this on Sep 8, 2021

Remove unused test files and references #9376