Improves the debug for AskFor() - removes the rather useless decimal display of time and the date format, and replaces with time from now, which is much easier to read (and speed read). Also now logs the sizes mapAskFor, mapAlreadyAskedFor and setAskFor.
Also creates a strAge() function which I think could be useful for various things (e.g. lastseen time, etc).
setAskFor, and mapAlreadyAskedFor
Fields with variable units are a real pain to parse from scripts.
Fields with variable units are a real pain to parse from scripts.
I know it's being done because of lack of a better interface to get various information in machine readable format, but arguably debug logs should not be considered an interface to other software, but are for troubleshooting by operators.
@rebroad I absolutely have. Let me put it another way: What possibly useful thing is anyone going to do with that data except parse it out and chart it to observe the behavior?
If it's your belief that people are actually not using it, then it should be removed, not pretty printed to a variable unit that is a real pain to create summary information from.
Any consistent unit is fine-- e.g. decimal minutes or whatever. it's fine to scale things to the most appropriate size for manual comparision. But varying the unit makes it much harder to programatically handle and sometimes even harder to manually compare... for little to no gain. @laanwj operators troubleshoot using machines to read the logs too.
@gmaxwell If you've used it to parse from then that is reason enough to leave it in, IMHO. Although given that there will be some who want human readable data and some who want machine readable data, then perhaps a command line option is called for (like the -h option on the du, df, ls, etc. commands)
No way we're going to introduce a command line option for an obscure bit of logging information.
What I would like is a more general framework for machine-readable statistics logging (like statoshi) that will log more and more useful information for producing timing summaries etc using external scripts.
Information such as this could then either be human-formatted or removed in the debug log depending on whether it is appropriate.
Until then I'd suggest closing this.
On Dec 25, 2016 06:53, "R E Broadley" notifications@github.com wrote:
@gmaxwell https://github.com/gmaxwell If you've used it to parse from then that is reason enough to leave it in, IMHO. Although given that there will be some who want human readable data and some who want machine readable data, then perhaps a command line option is called for....
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/9388#issuecomment-269111276, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHutm2k6FEITUcmJKvh7Vd1NJ-V--RJks5rLgTAgaJpZM4LR7CU .