travis: make distdir #9390

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1612-travisDistDir changing 2 files +1 −1

MarcoFalke commented at 9:56 PM on December 20, 2016: member

@theuni This should be enough to get back the test, which was removed due to 142ffc7e?

Edit: Also added an unrelated commit which removes a line in gitignore. (No longer needed, as the java comparision tool was removed)
travis: make distdir fad632ed7a
MarcoFalke added the label Tests on Dec 20, 2016
MarcoFalke added this to the milestone 0.14.0 on Dec 20, 2016
MarcoFalke requested review from theuni on Dec 20, 2016
gitignore: Wipe line after java comp tool removal fad896df19
fanquake commented at 11:29 PM on December 20, 2016: member

utACK fad896d, post #9376 merge.
theuni approved
theuni commented at 11:47 PM on December 20, 2016: member

fails in .17 sec, I assume it'll take < 1sec to pass. Looks good to me :)
in .travis.yml:None in fad896df19
```
  59 | @@ -60,6 +60,7 @@ script:
  60 |      - mkdir build && cd build
  61 |      - ../configure $BITCOIN_CONFIG_ALL $BITCOIN_CONFIG || ( cat config.log && false)
  62 |      - make $MAKEJOBS $GOAL || ( echo "Build failure. Verbose build follows." && make $GOAL V=1 ; false )
```
MarcoFalke commented at 12:56 AM on December 21, 2016:

@theuni I'd rather have it build the distributed files, to catch errors like #9393

MarcoFalke commented at 1:00 AM on December 21, 2016:

Though, this requires calling configure twice, I assume...
theuni commented at 4:13 AM on December 21, 2016:

@MarcoFalke Yea, I don't think there's any way around configuring twice for that. There is a built-in that uses the cache to save some time, though.

Just change the:

make $MAKEJOBS check VERBOSE=1

to

make $MAKEJOBS distcheck VERBOSE=1

I think that should actually work these days.
laanwj commented at 8:09 AM on December 21, 2016:

If this takes extra time, we could have only one of the builds do this. The distdir is arch-independent, after all.

MarcoFalke commented at 1:17 PM on December 21, 2016:

I think, if I change check to distcheck, it will compile twice, which is worse than configure twice?
laanwj commented at 8:27 AM on December 21, 2016: member

Restarting travis now that #9393 and #9376 merged
fanquake commented at 8:42 AM on December 21, 2016: member

Looks like it's taking just over 1 second on each build.
laanwj commented at 10:24 AM on December 21, 2016: member

Looks like it's taking just over 1 second on each build.

Then it's not worth spending more time optimizing this, there's bigger fish to fry. Thanks for measuring. ACK fad896d
laanwj merged this on Dec 21, 2016
laanwj closed this on Dec 21, 2016
laanwj referenced this in commit 8b4127fd4e on Dec 21, 2016
MarcoFalke deleted the branch on Dec 21, 2016
codablock referenced this in commit 199170e5d5 on Jan 18, 2018
andvgal referenced this in commit 2f8ab4c927 on Jan 6, 2019
CryptoCentric referenced this in commit 96235284e4 on Feb 26, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Milestone
0.14.0

Linked (view graph)

#9399 travis: make distdir before make #9416 travis: make distdir before make