Wallet ancestor sanity-check ignores sigops #9392

issue TheBlueMatt opened this issue on December 20, 2016
  1. TheBlueMatt commented at 11:56 PM on December 20, 2016: contributor

    As noted at in the discussion for #9262 (see #9262 (review) and #9262 (review)) the version of #9262 merged for 0.13.2 backport doesnt take into account sigops.

    The real fix for this is to provide a decent API from mempool to query if a transaction would violate the mempool's limits.

  2. fanquake added the label Wallet on Dec 20, 2016
  3. MarcoFalke added the label Feature on Dec 21, 2016
  4. MarcoFalke added this to the milestone 0.14.0 on Dec 21, 2016
  5. MarcoFalke added the label Mempool on Dec 21, 2016
  6. TheBlueMatt commented at 10:52 PM on January 18, 2017: contributor

    This isnt so trivial, as it turns out...the sigops stuff needs access to a CCoinsViewCache with all of a transaction's inputs, which is hard to generate from wallet. Probably untag for 0.14, and maybe just drop this one alltogether (I dont think it matters all that much?)

  7. instagibbs commented at 2:55 PM on February 8, 2017: member

    @TheBlueMatt This is why I originally didn't do it. I agree this is likely out of scope for 0.14.

  8. MarcoFalke removed this from the milestone 0.14.0 on Feb 9, 2017
  9. MarcoFalke commented at 7:26 PM on February 9, 2017: member

    Removed 0.14 tag as per current irc log.

  10. adamjonas commented at 3:43 PM on July 25, 2022: member

    Probably untag for 0.14, and maybe just drop this one alltogether (I dont think it matters all that much?)

    Closing for lack of movement (and low priority).

  11. adamjonas closed this on Jul 25, 2022

  12. bitcoin locked this on Jul 25, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me