Add test for -walletrejectlongchains #9395

1. 
   morcos commented at 1:32 AM on December 21, 2016: member

   txNew was moved from to create wtxNew so we don't really mean to be accessing it afterwards.

   The current code is not actually calculating mempool ancestors so -walletrejectlongchains is not having any effect.

2. fanquake added the label Mempool on Dec 21, 2016
3. fanquake added the label Wallet on Dec 21, 2016
4. 
   dcousens commented at 1:41 AM on December 21, 2016: contributor

   Tests?

5. 
   sipa commented at 1:50 AM on December 21, 2016: member

   As the CTransaction::CTransaction(CMutableTransaction&& x) constructor that destroys the passed-in object does not exist in 0.13, the backport is actually fine. But we do need to fix this in master.

6. MarcoFalke added this to the milestone 0.14.0 on Dec 21, 2016
7. 
   morcos commented at 2:57 AM on December 21, 2016: member

   @dcousens ok test added

8. in qa/rpc-tests/wallet.py:None in 6c174aee99 outdated

    386 | +        # Double chain limit but require combining inputs, so we pass SelectCoinsMinConf
    387 | +        stop_node(self.nodes[0],0)
    388 | +        self.nodes[0] = start_node(0, self.options.tmpdir, ["-walletrejectlongchains", "-limitancestorcount="+str(2*chainlimit)])
    389 | +
    390 | +        # wait for loadmempool
    391 | +        timeout = 10
   

   ---

   ---

   

   instagibbs commented at 3:02 AM on December 21, 2016:

   unused value?

   ---

   

   morcos commented at 3:09 AM on December 21, 2016:

   oops thanks.. adding the update of timeout

9. 
   dcousens commented at 3:04 AM on December 21, 2016: contributor

   Awesome, thanks @morcos

10. instagibbs approved
11. 
    instagibbs commented at 3:05 AM on December 21, 2016: member

    utACK

12. morcos force-pushed on Dec 21, 2016
13. 
    gmaxwell commented at 9:10 AM on December 21, 2016: contributor

    utACK

14. 
    MarcoFalke commented at 12:37 PM on December 21, 2016: member

    utACK 2f882f8

15. jonasschnelli approved
16. 
    jonasschnelli commented at 3:48 PM on December 21, 2016: contributor

    Thanks for fixing this. utACK 2f882f899904ab51412da463fd1854fd24426d21

17. 
    gmaxwell commented at 3:54 PM on January 4, 2017: contributor

    ACK-before-it-was-conflicted needs rebase.

18. add test for -walletrejectlongchains ffeb1956cb
19. morcos force-pushed on Jan 4, 2017
20. 
    morcos commented at 6:30 PM on January 4, 2017: member

    This was fixed in #9283, but still is useful to add the test, so kept that commit . (and changed PR title)

21. morcos renamed this:
    Actually calculate mempool ancestors
    Add test for -walletrejectlongchains
    on Jan 4, 2017
22. MarcoFalke added the label Tests on Jan 4, 2017
23. 
    MarcoFalke commented at 7:15 PM on January 4, 2017: member

    re-ACK ffeb1956cb4eec7be205c994d5cd89bb98283e9e

24. MarcoFalke added the label Needs backport on Jan 4, 2017
25. MarcoFalke added this to the milestone 0.13.3 on Jan 4, 2017
26. MarcoFalke removed this from the milestone 0.14.0 on Jan 4, 2017
27. MarcoFalke merged this on Jan 4, 2017
28. MarcoFalke closed this on Jan 4, 2017

    ---

29. MarcoFalke referenced this in commit 0fc1c31a87 on Jan 4, 2017
30. codablock referenced this in commit d2a8ecc8db on Jan 18, 2018
31. fanquake removed the label Needs backport on Mar 7, 2018
32. andvgal referenced this in commit 2533f3cfcf on Jan 6, 2019
33. CryptoCentric referenced this in commit b3ac13a765 on Feb 26, 2019
34. MarcoFalke locked this on Sep 8, 2021

Contributors

morcosdcousenssipainstagibbsgmaxwellMarcoFalkejonasschnelli

Milestone
0.13.3