Right now, CoinControl does only warn if the custom change address is not owned by the wallet. Sending is still possible. It will silently take another non-custom change address.
This PR will allow custom non-wallet-owned change addresses after accepting a warn-message-box.
Should fix #9410.
"Are you sure you want to use this – to the wallet unkonwn – change address?
suggested: "The address you selected for change is not part of this wallet. Any or all funds in your wallet may be sent to this address. Are you sure?"
(as an aside, it took me a moment of thought to realize why you thought it was dangerous-- so making the warning explicit my reduce the risk.)
@gmaxwell: Thanks. Switched to your recommendation. Also made sure that the custom change address input field gets cleared when the user did reject the confirmation-message-box.
Concept ACK.
utACK.
Post merge ACK