Use compact blocks for blocks that have equal work to our active tip #9427

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:UseCmpctBlockForCompetingBlocks changing 1 files +1 −1

rebroad commented at 7:52 AM on December 26, 2016: contributor

Currently, the check for downloading a block is different here than it is in the parallel block fetch code, which means that we always request the full block when we could be using the compact block. This commit allows the compact block received to be utilized.

As a future improvement, we can add logic to allow the TXs in the latest block to be utilized also, saving them from being re-fetched due to not being in the mempool.
rebroad renamed this:
~~Use compact blocks for blocks that are levl with our active tip rather than requesting a full block~~
Use compact blocks for blocks that have equal work to our active tip rather than requesting a full block
on Dec 26, 2016
rebroad renamed this:
~~Use compact blocks for blocks that have equal work to our active tip rather than requesting a full block~~
Use compact blocks for blocks that have equal work to our active
on Dec 26, 2016
rebroad renamed this:
~~Use compact blocks for blocks that have equal work to our active~~
Use compact blocks for blocks that have equal work to our active tip
on Dec 26, 2016

Use compact blocks for blocks that have equal work to our current active

tip (rather than requesting a full block each time).

Currently, the check for downloading a block is different here than it
is in the parallel block fetch code, which means that we always request
the full block when we could be using the compact block. This commit
allows the compact block received to be utilized.

2eaf4b468d

rebroad force-pushed on Dec 26, 2016
fanquake added the label P2P on Dec 26, 2016
fanquake commented at 12:59 PM on May 18, 2017: member

Closing due to no discussion. Will re-open if someone comments.
fanquake closed this on May 18, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

rebroad

fanquake

Labels

P2P

Linked (view graph)

#9428 WIP: Don't download blocks unless they have more work than our current best