invalid HTML code in Qt string for Wallet #945

Diapolo commented at 2:04 PM on March 17, 2012: none

The small HTML code starting at https://github.com/bitcoin/bitcoin/blob/master/src/qt/locale/bitcoin_en.ts#L907 is invalid (checked via http://validator.w3.org/#validate_by_input):

It has an invalid DOCTYPE, is missing the title-tag and the meta-tag is in XHTML style, which is not allowed for HTML 4.01. I did not open a pull request, as I don't want to edit the english source file and hope for an lupdate of it, which should be done before this one get's fixed.

Edit: Had to remove all HTML-code, as this breaks the layout here :-/.

laanwj commented at 2:21 PM on March 17, 2012: member

Thanks for noticing. There isn't supposed to be HTML there in the first place, QT creator must have added it.

Diapolo commented at 2:29 PM on March 17, 2012: none

No problem, even small glitches are worth to get discovered and fixed, to produce a "perfect" product :). Some other parts of the code contain HTML-tags for writing bold or to do a line break, is this supported and can be used in translations for text layout?

Example: https://github.com/bitcoin/bitcoin/blob/master/src/qt/locale/bitcoin_en.ts#L180

laanwj commented at 2:54 PM on March 17, 2012: member

Yes, it's fine to have <b> or <i> etc, but there should be no html/body headers, or font changes to fonts only present on one Linux distribution :)

The only problem with fixing this is that all translations have to be changed too.

Diapolo commented at 3:26 PM on March 17, 2012: none

There are 32 language files, so yes it's a bit work. But what would be the cleanest way to do this, update main file (english), do an lupdate, push to Transifex, let translators do their jobs? And how does the fixed string look like? I will update the german translation as soon as it's possible to do it ... perhaps I can help in fixing the other languages, too (not translation wise, but only to get rid of the HTML mess).

I hope someone can finally do that magic "lupdate", so all strings can be translated (see issue: #940).

laanwj commented at 3:30 PM on March 17, 2012: member

If we want translators to do it, we have to wait at least until after the final 0.6.0 release, otherwise "Wallet" will remain untranslated for a lot of languages in the coming release.

I'd prefer changing them all at once (either manually or with a script), but I don't have any experience with the transifex syncing and don't want to mess it up. Transifex is leading so it should be changed there first, before it goes to git.

Diapolo commented at 3:38 PM on March 17, 2012: none

I guess tcatm (Nils Schneider) could help, as I don't know how to proceed from here, too. Any idea how to point him to this issue ;)?

From the documentation:

Source file src/qt/locale/bitcoin_en.ts is a treated in a special way. It is used as the source for all other translations. Whenever a string in the code is change this file must be updated to reflect those changes. Usually, this can be accomplished by running lupdate

Diapolo commented at 9:33 AM on March 19, 2012: none

Well I think best solution would be really to do this after 0.6, to have a sufficient time window for all translations to get updated.

Diapolo commented at 7:11 AM on March 28, 2012: none

Could someone set the milestone to 0.7 for this, as the word "Wallet" will need to get re-translated, which should be possible very early in the 0.7 development.

And someone needs to fix it, by removing the HTML part completely ... I could do that, but I'm not sure, about the font settings for this specific translations. If it only needs to be "Wallet" without anything, I will open a commit.

laanwj commented at 6:17 AM on March 29, 2012: member

I'd still prefer one person to update all the translations in this case. It is a pretty trivial (even programmatic) operation, which will be the same for every language. Indeed, just strip the HTML so it says "Wallet". Let's not bother the translators with it, who might also get it wrong.

And yes this ACK for 0.7.

Diapolo commented at 6:37 AM on March 29, 2012: none

There is a font formatting used for "Wallet" (size 11 and it looks bold). This would add tags into overviewpage.ui instead of the HTML code. Is this okay or how is the default for setting that stuff for a label, if not in the designer.

laanwj referenced this in commit 3118d11d88 on May 5, 2012

Diapolo commented at 9:28 AM on May 5, 2012: none

As #945 got merged, we now need to update the en master file in our master branch.

Diapolo commented at 1:52 PM on May 11, 2012: none

Fixed and the new master file containing this change is in Transifex -> close!

Diapolo closed this on May 11, 2012

coblee referenced this in commit c6052d8bbc on Jul 17, 2012

suprnurd referenced this in commit 7d55e623a8 on Dec 5, 2017

ptschip referenced this in commit 23b81b001c on Jan 25, 2018

DrahtBot locked this on Sep 8, 2021