getaddr over RPC #9463

issue chris-belcher openend this issue on January 3, 2017
  1. chris-belcher commented at 5:38 pm on January 3, 2017: contributor

    A proposed new feature / RPC call.

    A way to get IP addresses of other bitcoin nodes known to your node via RPC.

    This would be useful for bitcoin wallets that unlink the source IP address from a transaction by connecting through tor to any bitcoin node out there for a short time. Examples of projects that might do this are JoinMarket (https://github.com/JoinMarket-Org/joinmarket/pull/662), laanwj’s submit-tx tool or anything else built on top of Bitcoin Core such as Armory.

    Right now these projects might use the DNS seeds instead, which are much less decentralized and which could be shut down to stop the tor-broadcast feature working.

    I think this new call would be exactly the same as the getaddr command from the p2p protocol but as an RPC instead.

  2. sipa commented at 5:51 pm on January 3, 2017: member
    Seems reasonable.
  3. fanquake added the label RPC/REST/ZMQ on Jan 3, 2017
  4. gmaxwell commented at 1:37 am on January 4, 2017: contributor
    Perhaps the RPC could take some filtering arguments, in particular service flags and recentness, maybe flags to use the tried vs not tried results? Not necessary for a first cut but might make them easier. (and even open up a new way of doing a dnsseed server; just proxy to the getaddr result :))
  5. dcousens commented at 2:16 am on January 4, 2017: contributor
    getrpcaddr getrpcinfo
  6. gmaxwell commented at 6:29 am on January 4, 2017: contributor
    @dcousens I don’t understand what ‘rpc’ is for in those lines.
  7. dcousens commented at 8:35 pm on January 4, 2017: contributor
    @gmaxwell disregard, I misread the OP.
  8. laanwj commented at 10:35 am on January 5, 2017: member
    Agree that this would be useful.
  9. kvsari commented at 0:24 am on February 11, 2017: none
    Please check out this WIP and let me know if I’m headed in the right direction.
  10. sipa commented at 0:49 am on February 11, 2017: member
    @kvsari Looks good codewise, but I think you’re solving a different problem. It’s already possible to know what IPs you’re connected to (use getpeerinfo). The request here is to get IPs your node knows about. Presumably its implementation would be similar to the handling of GETADDR in net_processing.cpp.
  11. MarcoFalke referenced this in commit d26278988f on Sep 18, 2018
  12. chris-belcher closed this on Sep 19, 2018

  13. deadalnix referenced this in commit 48916ac854 on Feb 12, 2020
  14. Munkybooty referenced this in commit f014a5bd91 on Jul 9, 2021
  15. PastaPastaPasta referenced this in commit 6503e1cf0e on Jul 19, 2021
  16. PastaPastaPasta referenced this in commit 13927cf23a on Jul 20, 2021
  17. vijaydasmp referenced this in commit 2b7cf4741c on Sep 8, 2021
  18. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me