[refactor] Remove using namespace <xxx> from rpc/ & script/ sources #9476

pull kallewoof wants to merge 2 commits into bitcoin:master from kallewoof:no-using-namespace-rpc-script changing 13 files +192 −218

kallewoof commented at 10:37 AM on January 5, 2017: member

This is a sub-set of #9235, including only the rpc and script dirs.

Same-binaries check (2017-03-08):

$ ../bitcoin-maintainer-tools/build-for-compare.py 6996e066b538f03b8aa1f617dbb959b57ff6e727 8cbfc4e47216cbf9e3e758604e23951f40d76cf9 --executables "src/bitcoind,src/bitcoin-cli,src/bitcoin-tx"
[...]
make[1]: Leaving directory '/tmp/repo/src'
>>> [do_build] Copying object files...
>>> [do_build] Performing basic analysis pass...
>>> [do_build] Use these commands to compare results:
>>> [do_build] $ sha256sum /tmp/compare/*.stripped
>>> [do_build] $ git diff -W --word-diff /tmp/compare/6996e066b538f03b8aa1f617dbb959b57ff6e727 /tmp/compare/8cbfc4e47216cbf9e3e758604e23951f40d76cf9
$ sha256sum /tmp/compare/*.stripped
1bfe4311525db52b9c5d5c2b0b9ff6f8e3f3cfda0dcb1e5cd83b08b767a4a902  /tmp/compare/bitcoin-cli.6996e066b538f03b8aa1f617dbb959b57ff6e727.stripped
1bfe4311525db52b9c5d5c2b0b9ff6f8e3f3cfda0dcb1e5cd83b08b767a4a902  /tmp/compare/bitcoin-cli.8cbfc4e47216cbf9e3e758604e23951f40d76cf9.stripped
fb0f6796776dc39e422910572a216cbad87f607cbb4920bd12d2c483cc51e231  /tmp/compare/bitcoind.6996e066b538f03b8aa1f617dbb959b57ff6e727.stripped
fb0f6796776dc39e422910572a216cbad87f607cbb4920bd12d2c483cc51e231  /tmp/compare/bitcoind.8cbfc4e47216cbf9e3e758604e23951f40d76cf9.stripped
fe4107fcc49ba17cdfbb0edc357373ea37d833d5691af7b2367758e8b3e1d45c  /tmp/compare/bitcoin-tx.6996e066b538f03b8aa1f617dbb959b57ff6e727.stripped
fe4107fcc49ba17cdfbb0edc357373ea37d833d5691af7b2367758e8b3e1d45c  /tmp/compare/bitcoin-tx.8cbfc4e47216cbf9e3e758604e23951f40d76cf9.stripped
$ git diff -W --word-diff /tmp/compare/6996e066b538f03b8aa1f617dbb959b57ff6e727 /tmp/compare/8cbfc4e47216cbf9e3e758604e23951f40d76cf9
$

The affected files and namespaces:

rpc/blockchain.cpp:       std
rpc/client.cpp:           std
rpc/mining.cpp:           std
rpc/misc.cpp:             std
rpc/net.cpp:              std
rpc/protocol.cpp:         std
rpc/rawtransaction.cpp:   std
rpc/server.cpp:           RPCServer [unused], std
script/interpreter.cpp:   std
script/ismine.cpp:        std
script/script.cpp:        std
script/sign.cpp:          std
script/standard.cpp:      std

fanquake added the label Refactoring on Jan 5, 2017
MarcoFalke commented at 10:42 AM on January 5, 2017: member

This might conflict with pending rpc and multiwallet changes, which are planned for 0.14.

Imo, we should wait until feature freeze in two weeks and then do the same-binary check on this pull and merge into 0.14 if it passes.
kallewoof commented at 10:44 AM on January 5, 2017: member

@MarcoFalke OK.
kallewoof renamed this:
~~Refactor: Remove using namespace <xxx> from rpc/ & script/ sources~~
[refactor] Remove using namespace <xxx> from rpc/ & script/ sources
on Jan 13, 2017
kallewoof force-pushed on Jan 18, 2017
kallewoof force-pushed on Jan 18, 2017
fanquake commented at 1:09 AM on January 21, 2017: member

Feature freeze is here. Please rebase this.
kallewoof force-pushed on Jan 23, 2017
kallewoof commented at 2:14 AM on January 23, 2017: member

@fanquake Rebased & redid binary comparison (ff58b1c vs 1eb9d53).
jtimon commented at 12:00 AM on February 24, 2017: contributor

utACK 1eb9d53
dcousens approved
MarcoFalke commented at 1:17 AM on February 24, 2017: member

utACK 1eb9d53
sipa commented at 3:31 AM on February 24, 2017: member

utACK
laanwj assigned laanwj on Mar 8, 2017
laanwj commented at 6:20 AM on March 8, 2017: member

Needs another rebase, sorry.
Refactor: Remove using namespace <xxx> from rpc/ f3c264e9a6
Refactor: Remove using namespace <xxx> from script/ 8cbfc4e472
kallewoof force-pushed on Mar 8, 2017
kallewoof commented at 4:28 PM on March 8, 2017: member

@laanwj Rebased & redid binary comparison (6996e066b538f03b8aa1f617dbb959b57ff6e727 vs 8cbfc4e47216cbf9e3e758604e23951f40d76cf9).
kallewoof force-pushed on Mar 8, 2017
kallewoof commented at 12:40 AM on March 9, 2017: member

I'm not sure why Travis is failing. Edit: It stopped failing.
kallewoof force-pushed on Mar 9, 2017
laanwj merged this on Mar 9, 2017
laanwj closed this on Mar 9, 2017
laanwj referenced this in commit 8152d3fe57 on Mar 9, 2017
UdjinM6 referenced this in commit ccca7af09e on Feb 21, 2018
andvgal referenced this in commit aab5d194c9 on Jan 6, 2019
CryptoCentric referenced this in commit 2589fb5e0b on Feb 28, 2019
kallewoof deleted the branch on Oct 17, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#9235 [WIP] Refactor: Remove all uses of using namespace in all source files.