build: fix qt distdir builds #9509

pull theuni wants to merge 1 commits into bitcoin:master from theuni:out-of-tree-build changing 1 files +3 −1

theuni commented at 8:58 PM on January 10, 2017: member

Just build the same way as the file above it.

Fixes the issue presented by #9416.
build: fix qt distdir builds 945008d336
theuni commented at 8:58 PM on January 10, 2017: member

@MarcoFalke I believe this should fix your issue.
MarcoFalke commented at 9:03 PM on January 10, 2017: member

Thanks for the fix.

utACK 945008d
fanquake added the label Build system on Jan 10, 2017

fanquake commented at 12:16 AM on January 11, 2017: member

OS X failed with:

Undefined symbols for architecture x86_64:
  "qInitResources_bitcoin()", referenced from:
      _main in qt_bitcoin_qt-bitcoin.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [qt/bitcoin-qt] Error 1
make[1]: Leaving directory `/home/travis/build/bitcoin/bitcoin/build/src'
make: *** [src/qt/bitcoin-qt] Error 2

Linux failed with:

qt/qt_bitcoin_qt-bitcoin.o: In function `main':
bitcoin.cpp:(.text.startup+0x13d): undefined reference to `qInitResources_bitcoin()'
collect2: error: ld returned 1 exit status
make[2]: *** [qt/bitcoin-qt] Error 1
make[2]: Leaving directory `/home/travis/build/bitcoin/bitcoin/build/src'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/home/travis/build/bitcoin/bitcoin/build/src'
make: *** [install-recursive] Error 1

theuni commented at 12:35 AM on January 11, 2017: member

Whoops, I remember what this is doing now. This is wrong.

We need to make the distinction between generated files and unchanging files. Since these aren't changed by the build, they need to come from srcdir rather than builddir. So it's correct as-is.
theuni closed this on Jan 11, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#9416 travis: make distdir before make #9513 build: fix qt distdir builds (retry)